Skip to content

yarn test ci runs node tests when configured for browser tests #10

@chrisgervang

Description

@chrisgervang

Hubble.gl tests are moving to browser-only tests and are failing since the ci test is running node tests. However, our ocular config (test.coverage) has testing configured for browser.

There may be a typo in test.sh:

if [ "$COVERAGE_TEST" == "browser" ]; then

Shouldn't this instead run node tests if coverage.test is node? Elsewhere in the dev tools (such as test.js), the default case is to run browser tests and the exception is to check if the value is node. Did we mean to do the same thing in test.sh?

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions