Skip to content

Commit 9631f51

Browse files
refactor(encoders): remove archive format, standardize zip (#314)
* refactor(encoders): remove archive format, standardize zip * Add doc to TOC --------- Co-authored-by: charlieforward9 <[email protected]>
1 parent c54ecc9 commit 9631f51

File tree

19 files changed

+58
-636
lines changed

19 files changed

+58
-636
lines changed

docs/api-reference/encoder/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ Encoders are used to capture image frames of an HTML `<canvas/>` and encode them
1313
| [`WebMEncoder`](/docs/api-reference/encoder/webm-encoder) | Video | Encodes `.webm` video using [Whammy](https://antimatter15.com/2012/08/whammy-a-real-time-javascript-webm-encoder/). |
1414
| [`GIFEncoder`](/docs/api-reference/encoder/gif-encoder) | Animated Image | Encodes `.gif` images using `gifshot.js`. |
1515
| [`StreamEncoder`](/docs/api-reference/encoder/stream-encoder) | Video | Encodes `.webm` rough previews, but drops frames. |
16-
| [`PNGSequenceEncoder`](/docs/api-reference/encoder/png-sequence-encoder) | Image Sequence | Encodes video frames as loseless `.png` contained in a `.tar`. |
17-
| [`JPEGSequenceEncoder`](/docs/api-reference/encoder/jpeg-sequence-encoder) | Image Sequence | Encodes video frames as compressed `.jpeg` contained in a `.tar`. |
16+
| [`PNGSequenceEncoder`](/docs/api-reference/encoder/png-sequence-encoder) | Image Sequence | Encodes video frames as loseless `.png` contained in a `.zip`. |
17+
| [`JPEGSequenceEncoder`](/docs/api-reference/encoder/jpeg-sequence-encoder) | Image Sequence | Encodes video frames as compressed `.jpeg` contained in a `.zip`. |
1818

1919
### Attributions
2020

docs/api-reference/encoder/jpeg-sequence-encoder.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# JPEGSequenceEncoder
22

3-
A photo sequence encoder that inherits [FrameEncoder](/docs/api-reference/encoder/frame-encoder). Saves each frame as a photo contained in a `".tar"` archive.
3+
A photo sequence encoder that inherits [FrameEncoder](/docs/api-reference/encoder/frame-encoder). Saves each frame as a photo contained in a `".zip"` archive.
44

55
## Constructor
66

@@ -12,7 +12,7 @@ In addition to the [FrameEncoder](/docs/api-reference/encoder/frame-encoder) set
1212

1313
* `quality` - See member note. Defaults to 1.0.
1414

15-
* `archive` - `zip` or `tar`. Defaults to `tar`.
15+
* `archive` - `zip`.
1616

1717
## Members
1818

docs/api-reference/encoder/png-sequence-encoder.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# PNGSequenceEncoder
22

3-
A photo sequence encoder that inherits [FrameEncoder](/docs/api-reference/encoder/frame-encoder). Saves each frame as a photo contained in a `".tar"` archive.
3+
A photo sequence encoder that inherits [FrameEncoder](/docs/api-reference/encoder/frame-encoder). Saves each frame as a photo contained in a `".zip"` archive.
44

55
## Constructor
66

@@ -10,7 +10,7 @@ Construction of the encoder class is not required. Refer to [DeckAdapter.render]
1010

1111
In addition to the [FrameEncoder](/docs/api-reference/encoder/frame-encoder) settings, these settings are available under the `png` namespace.
1212

13-
* `archive` - `zip` or `tar`. Defaults to `tar`.
13+
* `archive` - `zip`.
1414

1515
**Notes:**
1616

docs/table-of-contents.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@
3030
"type": "category",
3131
"label": "Animations",
3232
"items": [
33-
"api-reference/animations/animation-manager"
33+
"api-reference/animations/animation-manager",
34+
"api-reference/animations/deck-animation"
3435
]
3536
},
3637
{

examples/website/basic-basemap-mapbox-legacy/app.jsx

Lines changed: 10 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,8 @@ const formatConfigs = {
5252
webm: {
5353
quality: 0.8
5454
},
55-
png: {
56-
archive: 'zip'
57-
},
55+
png: {},
5856
jpeg: {
59-
archive: 'zip',
6057
quality: 0.8
6158
},
6259
gif: {
@@ -73,17 +70,16 @@ const timecode = {
7370
};
7471

7572
const DeckGLOverlay = forwardRef((props, ref) => {
76-
// MapboxOverlay handles a variety of props differently than the Deck class.
77-
// https://deck.gl/docs/api-reference/mapbox/mapbox-overlay#constructor
78-
const deck = useControl(() => new MapboxOverlay({...props, interleaved: true}));
73+
// MapboxOverlay handles a variety of props differently than the Deck class.
74+
// https://deck.gl/docs/api-reference/mapbox/mapbox-overlay#constructor
75+
const deck = useControl(() => new MapboxOverlay({...props, interleaved: true}));
7976

80-
deck.setProps(props);
77+
deck.setProps(props);
8178

82-
// @ts-expect-error private property
83-
setRef(ref, deck._deck);
84-
return null;
85-
}
86-
);
79+
// @ts-expect-error private property
80+
setRef(ref, deck._deck);
81+
return null;
82+
});
8783

8884
const Container = ({children}) => (
8985
<div
@@ -169,10 +165,7 @@ export default function App({mapStyle = 'mapbox://styles/mapbox/streets-v11'}) {
169165
onMove={onViewStateChange}
170166
// Note: 'reuseMap' prop with gatsby and mapbox extension causes stale reference error.
171167
>
172-
<DeckGLOverlay
173-
ref={deckRef}
174-
{...deckProps}
175-
/>
168+
<DeckGLOverlay ref={deckRef} {...deckProps} />
176169
</Map>
177170
</div>
178171
<BasicControls

examples/website/basic-basemap-mapbox/app.jsx

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,8 @@ const formatConfigs = {
5252
webm: {
5353
quality: 0.8
5454
},
55-
png: {
56-
archive: 'zip'
57-
},
55+
png: {},
5856
jpeg: {
59-
archive: 'zip',
6057
quality: 0.8
6158
},
6259
gif: {
@@ -82,8 +79,7 @@ const DeckGLOverlay = forwardRef((props, ref) => {
8279
// @ts-expect-error private property
8380
setRef(ref, deck._deck);
8481
return null;
85-
}
86-
);
82+
});
8783

8884
const Container = ({children}) => (
8985
<div
@@ -169,10 +165,7 @@ export default function App({mapStyle = 'mapbox://styles/mapbox/streets-v11'}) {
169165
onMove={onViewStateChange}
170166
// Note: 'reuseMap' prop with gatsby and mapbox extension causes stale reference error.
171167
>
172-
<DeckGLOverlay
173-
ref={deckRef}
174-
{...deckProps}
175-
/>
168+
<DeckGLOverlay ref={deckRef} {...deckProps} />
176169
</Map>
177170
</div>
178171
<BasicControls

examples/website/basic-basemap/app.jsx

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,8 @@ const formatConfigs = {
5353
webm: {
5454
quality: 0.8
5555
},
56-
png: {
57-
archive: 'zip'
58-
},
56+
png: {},
5957
jpeg: {
60-
archive: 'zip',
6158
quality: 0.8
6259
},
6360
gif: {
@@ -108,7 +105,9 @@ const randomColor = () => [
108105
Math.floor(Math.random() * 255)
109106
];
110107

111-
export default function App({mapStyle = 'https://basemaps.cartocdn.com/gl/positron-gl-style/style.json'}) {
108+
export default function App({
109+
mapStyle = 'https://basemaps.cartocdn.com/gl/positron-gl-style/style.json'
110+
}) {
112111
const deckRef = useRef(null);
113112
const mapRef = useRef(null);
114113
const [busy, setBusy] = useState(false);
@@ -170,10 +169,7 @@ export default function App({mapStyle = 'https://basemaps.cartocdn.com/gl/positr
170169
mapLib={maplibregl}
171170
// Note: 'reuseMap' prop with gatsby and mapbox extension causes stale reference error.
172171
>
173-
<DeckGLOverlay
174-
ref={deckRef}
175-
{...deckProps}
176-
/>
172+
<DeckGLOverlay ref={deckRef} {...deckProps} />
177173
</Map>
178174
</div>
179175
<BasicControls

examples/website/camera/app.jsx

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,9 @@ const formatConfigs = {
2727
webm: {
2828
quality: 0.8
2929
},
30-
png: {
31-
archive: 'zip'
32-
},
30+
png: {},
3331
jpeg: {
34-
quality: 0.8,
35-
archive: 'zip'
32+
quality: 0.8
3633
},
3734
gif: {
3835
sampleInterval: 1000,

examples/website/terrain/app.jsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -101,11 +101,8 @@ const formatConfigs = {
101101
webm: {
102102
quality: 0.8
103103
},
104-
png: {
105-
archive: 'zip'
106-
},
104+
png: {},
107105
jpeg: {
108-
archive: 'zip',
109106
quality: 0.8
110107
},
111108
gif: {

examples/website/trips/app.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,11 +78,8 @@ const formatConfigs = {
7878
webm: {
7979
quality: 0.8
8080
},
81-
png: {
82-
archive: 'zip'
83-
},
81+
png: {},
8482
jpeg: {
85-
archive: 'zip',
8683
quality: 0.8
8784
},
8885
gif: {

0 commit comments

Comments
 (0)