handle: move lookupByDump from HandleOptions to Handle

This is not really a configuration option, but rather an internal cache for
remembering the lookup fallback behaviour.

Signed-off-by: Timo Beckers <timo@incline.eu>

Author: ti-mo

handle_linux.go

@@ -13,7 +13,6 @@ import (
 var pkgHandle = &Handle{}
 
 type HandleOptions struct {
-	lookupByDump     bool
 	collectVFInfo    bool
 	retryInterrupted bool
 }
@@ -25,6 +24,8 @@ type HandleOptions struct {
 type Handle struct {
 	sockets map[int]*nl.SocketHandle
 	options HandleOptions
+
+	lookupByDump bool
 }
 
 // DisableVFInfoCollection configures the handle to skip VF information fetching

link_linux.go

@@ -2020,7 +2020,7 @@ func LinkByName(name string) (Link, error) {
 // filtering a dump of all link names. In this case, if the returned error is
 // [ErrDumpInterrupted] the result may be missing or outdated.
 func (h *Handle) LinkByName(name string) (Link, error) {
-	if h.options.lookupByDump {
+	if h.lookupByDump {
 		return h.linkByNameDump(name)
 	}
 
@@ -2044,7 +2044,7 @@ func (h *Handle) LinkByName(name string) (Link, error) {
 	if err == unix.EINVAL {
 		// older kernels don't support looking up via IFLA_IFNAME
 		// so fall back to dumping all links
-		h.options.lookupByDump = true
+		h.lookupByDump = true
 		return h.linkByNameDump(name)
 	}
 
@@ -2068,7 +2068,7 @@ func LinkByAlias(alias string) (Link, error) {
 // filtering a dump of all link names. In this case, if the returned error is
 // [ErrDumpInterrupted] the result may be missing or outdated.
 func (h *Handle) LinkByAlias(alias string) (Link, error) {
-	if h.options.lookupByDump {
+	if h.lookupByDump {
 		return h.linkByAliasDump(alias)
 	}
 
@@ -2089,7 +2089,7 @@ func (h *Handle) LinkByAlias(alias string) (Link, error) {
 	if err == unix.EINVAL {
 		// older kernels don't support looking up via IFLA_IFALIAS
 		// so fall back to dumping all links
-		h.options.lookupByDump = true
+		h.lookupByDump = true
 		return h.linkByAliasDump(alias)
 	}