Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Further customize shapes #713

Open
cristianocca opened this issue May 16, 2020 · 2 comments
Open

[Feature Request] Further customize shapes #713

cristianocca opened this issue May 16, 2020 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@cristianocca
Copy link
Contributor

Shapes are great, but could we add a little more customization to them? Right now they can only be resized with the value property. It would be great to be able to adjust width/height of boxes, radius of circles, etc. What's the rationale for not supporting this/

I know this can be achieved with SVG images, but it gets much heavier and harder to maintain than just passing props to the box shape.

Thoughts?

@cristianocca cristianocca changed the title [Feature Request] [Feature Request] Further customize shapes May 16, 2020
@Thomaash Thomaash added enhancement New feature or request help wanted Extra attention is needed labels May 16, 2020
@Thomaash
Copy link
Member

Box is shaped according to the text inside. If the text is inside it would be pretty difficult to deal with this and also there is the question what to do with the text (downscale/upscale/overflow/etc).

As for the others, I don't really see a reason why not. It shouldn't be that difficult to achieve. However there are much more pressing issues requiring my very limited time so if you want this functionality you'll have to code it yourself (and thank you very much if you do) or find someone willing to work on it.

@cristianocca
Copy link
Contributor Author

For the box shape, there's already logic/options for max width/height a box is allowed to grow when there's text in it. I'm assuming this logic already deals with text wrapping and such, wouldn't it be as simple as just "fixing" the width/height of the box and let the text wrap in it? Sorry if I'm over simplifying it, I haven't really looked into the code.

Since I can right now work around this with SVG shapes, it is not so urgent for me neither, but I would be willing to implement it if required. Some hints about where to look at in the code would also be helpful :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants