fix: fixed all recommendations by @ptbrowne

Author: noahonyejese

Diff for: src/components/charts-generic/histogram/histogram-state.tsx

@@ -73,7 +73,7 @@ const useHistogramState = ({
 
   const colors = scaleLinear<string>()
     .domain(colorDomain)
-    .range(chartPalette.diverging.GO)
+    .range(chartPalette.diverging.GreenOrange)
     .interpolate(interpolateHsl);
   // y
   const bins = bin<GenericObservation, number>()

Diff for: src/components/charts-generic/rangeplot/rangeplot-state.tsx

@@ -99,7 +99,7 @@ const useRangePlotState = ({
 
   const colors = scaleLinear<string, string>()
     .domain(colorDomain)
-    .range(chartPalette.diverging.GO)
+    .range(chartPalette.diverging.GreenOrange)
     .interpolate(interpolateLab);
   const left = estimateTextWidth(
     yScale.domain().length > 1

Diff for: src/components/price-color-legend.tsx

@@ -225,7 +225,7 @@ const ColorsLine = () => {
           borderTop: `${COLOR_HEIGHT / 2}px solid transparent`,
           borderBottom: `${COLOR_HEIGHT / 2}px solid transparent`,
           borderRight: `${COLOR_HEIGHT / 2}px solid  ${
-            chartPalette.diverging.GO[0]
+            chartPalette.diverging.GreenOrange[0]
           }`,
         }}
       />
@@ -238,7 +238,7 @@ const ColorsLine = () => {
           width: "100%",
         }}
       >
-        {chartPalette.diverging.GO.map((bg, i) => (
+        {chartPalette.diverging.GreenOrange.map((bg, i) => (
           <Box
             key={bg}
             sx={{
@@ -279,7 +279,9 @@ const ColorsLine = () => {
           borderTop: `${COLOR_HEIGHT / 2}px solid transparent`,
           borderBottom: `${COLOR_HEIGHT / 2}px solid transparent`,
           borderLeft: `${COLOR_HEIGHT / 2}px solid ${
-            chartPalette.diverging.GO[chartPalette.diverging.GO.length - 1]
+            chartPalette.diverging.GreenOrange[
+              chartPalette.diverging.GreenOrange.length - 1
+            ]
           }`,
         }}
       />

Diff for: src/domain/data.ts

@@ -57,7 +57,7 @@ export const useColorScale = ({
     const domain = [m * 0.85, m * 0.95, m * 1.05, m * 1.15];
     const scale = scaleThreshold<number, string>()
       .domain(domain)
-      .range(chartPalette.diverging.GO);
+      .range(chartPalette.diverging.GreenOrange);
 
     return scale;
   }, [medianValue]);

Diff for: src/themes/index.d.ts

@@ -1,6 +1,5 @@
 import {
   FederalBreakpointOverrides,
-  FederalColor,
   FederalTypographyPropsVariantOverrides,
   FederalTypographyVariants,
   FederalTypographyVariantsOptions,
@@ -52,7 +51,6 @@ declare module "@mui/material/styles" {
   interface BreakpointOverrides extends FederalBreakpointOverrides {}
 
   interface Palette {
-    cobalt: FederalColor & { main: string };
     tertiary: { main: string };
   }
 

Diff for: src/themes/palette.ts

@@ -4,17 +4,17 @@ import { type ThemeOptions } from "@mui/material";
 export const palette = {
   ...colors,
   text: {
-    primary: colors.monochrome[800],
     ...colors.monochrome,
+    primary: colors.monochrome[800],
   },
   primary: {
+    ...colors.red,
     main: "#D8232A",
     contrastText: "#FFFFFF",
-    ...colors.red,
   },
   secondary: {
-    main: colors.cobalt[700],
     ...colors.cobalt,
+    main: colors.cobalt[700],
   },
   tertiary: {
     main: colors.monochrome[800],
@@ -42,7 +42,7 @@ export const chartPalette = {
     pink: ["#FBCFE8", "#F9A8D4", "#F472B6", "#EC4899", "#DB2777", "#BE185D"],
   },
   diverging: {
-    GO: ["#059669", "#34D399", "#E4D78C", "#FB923C", "#EA580C"],
-    BP: ["#2563EB", "#60A5FA", "#CEC3DE", "#F472B6", "#DB2777"],
+    GreenOrange: ["#059669", "#34D399", "#E4D78C", "#FB923C", "#EA580C"],
+    BluePink: ["#2563EB", "#60A5FA", "#CEC3DE", "#F472B6", "#DB2777"],
   },
 };

Diff for: src/themes/shadows.ts

@@ -1,7 +1,30 @@
-import { e } from "@interactivethings/swiss-federal-ci";
+import { e as swissFederalCiShadows } from "@interactivethings/swiss-federal-ci";
 import { Shadows } from "@mui/material/styles/shadows";
 
-export const shadows = Array.from({ length: 25 }, (_, i) => {
-  const index = Math.floor(i / 4);
-  return e[Math.min(index, e.length - 1)];
-}) as Shadows;
+export const shadows = [
+  swissFederalCiShadows[1],
+  swissFederalCiShadows[1],
+  swissFederalCiShadows[1],
+  swissFederalCiShadows[1],
+  swissFederalCiShadows[1],
+  swissFederalCiShadows[1],
+  swissFederalCiShadows[1],
+  swissFederalCiShadows[1],
+  swissFederalCiShadows[1],
+  swissFederalCiShadows[2],
+  swissFederalCiShadows[2],
+  swissFederalCiShadows[2],
+  swissFederalCiShadows[2],
+  swissFederalCiShadows[3],
+  swissFederalCiShadows[3],
+  swissFederalCiShadows[3],
+  swissFederalCiShadows[3],
+  swissFederalCiShadows[4],
+  swissFederalCiShadows[4],
+  swissFederalCiShadows[4],
+  swissFederalCiShadows[4],
+  swissFederalCiShadows[5],
+  swissFederalCiShadows[5],
+  swissFederalCiShadows[5],
+  swissFederalCiShadows[5],
+] as Shadows;