Skip to content

Commit 6b11249

Browse files
committed
refactor: Only require what's actually needed
1 parent 9cd2c06 commit 6b11249

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

app/charts/column/columns-grouped-state-props.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ export const useColumnsGroupedStateVariables = (
6262
measuresById,
6363
});
6464
const numericalYErrorVariables = useNumericalYErrorVariables(y, {
65-
numericalYVariables,
65+
getValue: numericalYVariables.getY,
6666
dimensions,
6767
measures,
6868
});

app/charts/column/columns-state-props.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ export const useColumnsStateVariables = (
5757
measuresById,
5858
});
5959
const numericalYErrorVariables = useNumericalYErrorVariables(y, {
60-
numericalYVariables,
60+
getValue: numericalYVariables.getY,
6161
dimensions,
6262
measures,
6363
});

app/charts/line/lines-state-props.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ export const useLinesStateVariables = (
5353
measuresById,
5454
});
5555
const numericalYErrorVariables = useNumericalYErrorVariables(y, {
56-
numericalYVariables,
56+
getValue: numericalYVariables.getY,
5757
dimensions,
5858
measures,
5959
});

app/charts/shared/chart-state.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -350,11 +350,11 @@ export type NumericalYErrorVariables = {
350350
export const useNumericalYErrorVariables = (
351351
y: GenericField,
352352
{
353-
numericalYVariables,
353+
getValue,
354354
dimensions,
355355
measures,
356356
}: {
357-
numericalYVariables: NumericalYVariables;
357+
getValue: NumericalYVariables["getY"];
358358
dimensions: Dimension[];
359359
measures: Measure[];
360360
}
@@ -409,7 +409,7 @@ export const useNumericalYErrorVariables = (
409409
showYStandardError && yStandardErrorMeasure
410410
? yStandardErrorMeasure
411411
: yConfidenceIntervalLowerMeasure,
412-
numericalYVariables.getY
412+
getValue
413413
);
414414
const getFormattedYUncertainty = useCallback(
415415
(d: Observation) => {

0 commit comments

Comments
 (0)