fix(react): avoid duplicate SW registration in strict mode#932
Open
cyphercodes wants to merge 1 commit into
Open
fix(react): avoid duplicate SW registration in strict mode#932cyphercodes wants to merge 1 commit into
cyphercodes wants to merge 1 commit into
Conversation
✅ Deploy Preview for vite-plugin-pwa-legacy ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves React
useRegisterSWservice worker registration out of theuseStatelazy initializer and into a guarded effect. The returnedupdateServiceWorkerfunction stays stable and forwards to the registered updater via a ref, so React StrictMode development double-invocation does not register the service worker twice.Added a focused Vitest coverage case that simulates StrictMode double-invoking state initializers/effects and verifies a single registration.
Linked Issues
Fixes #925
Additional Context
Verification:
pnpm run test-clientpnpm run lintpnpm run buildpnpm -C examples/react-router run run-build-claims && pnpm -C examples/react-router exec vitest runpnpm -C examples/react-router run run-build-sw-claims && SW=true pnpm -C examples/react-router exec vitest rungit diff --check