fix: emit manifest.webmanifest relative to custom outDir#934
Closed
jack-old-archive wants to merge 2 commits into
Closed
fix: emit manifest.webmanifest relative to custom outDir#934jack-old-archive wants to merge 2 commits into
jack-old-archive wants to merge 2 commits into
Conversation
Closes #919. The manifest file was always emitted to the root of the main Vite build output, ignoring the custom option. This fix calculates the relative subdirectory and emits the manifest correctly alongside other PWA assets like sw.js and icons.'
❌ Deploy Preview for vite-plugin-pwa-legacy failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #919.
Problem
When configuring a custom
outDir(e.g.,outDir: 'dist/client/_pwa'), the service worker (sw.js) and icons were correctly placed inside the_pwadirectory. However,manifest.webmanifestwas always generated in the root of the build output (e.g.,dist/client/manifest.webmanifest), ignoring theoutDiroption.Solution
Calculate the relative path from the main Vite build output directory to the PWA custom output directory, and use this relative path when emitting the manifest file via
emitFile.Changes
joinandrelativeto imports._generateBundleto computemanifestFileNamebased on the relative subdirectory between the Vitebuild.outDirand the PWAoutDir.Verification
Using the configuration: