build failed with pnpm

[nstringham]

When using pnpm I get the following error:

Error: [vite]: Rolldown failed to resolve import "workbox-window" from "/@vite-plugin-pwa/virtual:pwa-register".

As a workaround I added this to my pnpm-workspace.yaml

publicHoistPattern:
  - "*workbox*"

According to the pnpm docs this config is necessary when a dependency plugin is not configured correctly.

[userquin]

Install workbox-window (pnpm add -D workbox-window, check installed versoin is 7.4.0 iirc)

[nstringham]

Is that the intended way? I feel like if we are expected to install workbox then it should be listed as a peer dependency right?

[s-r-x]

@nstringham it shouldn't be a peer dependency, cause workbox-window doesn't have to be installed if you don't use the virtual modules (like virtual:pwa-register/react), which ofc is impossible to determine beforehand for your package manager. imagine installing a package that screams at you "you 100% must also install this thing, even though you might not need it"

[nstringham]

What about an optional peer dependacy?