Skip to content

Commit bfe9db9

Browse files
committed
chore: fix unexpected rebase error
1 parent b56cda1 commit bfe9db9

File tree

1 file changed

+2
-37
lines changed
  • packages/vite/src/node/optimizer

1 file changed

+2
-37
lines changed

packages/vite/src/node/optimizer/index.ts

+2-37
Original file line numberDiff line numberDiff line change
@@ -715,45 +715,34 @@ async function prepareRolldownOptimizerRun(
715715

716716
const optimizeDeps = getDepOptimizationConfig(config, ssr)
717717

718-
const { plugins: pluginsFromConfig = [], ...rollupOptions } =
719-
optimizeDeps?.rollupOptions ?? {}
720718
const { plugins: pluginsFromConfig = [], ...rollupOptions } =
721719
optimizeDeps?.rollupOptions ?? {}
722720

723-
let jsxLoader = false
724721
let jsxLoader = false
725722
await Promise.all(
726723
Object.keys(depsInfo).map(async (id) => {
727724
const src = depsInfo[id].src!
728725
const exportsData = await (depsInfo[id].exportsData ??
729726
extractExportsData(src, config, ssr))
730-
if (exportsData.jsxLoader) {
731727
if (exportsData.jsxLoader) {
732728
// Ensure that optimization won't fail by defaulting '.js' to the JSX parser.
733729
// This is useful for packages such as Gatsby.
734730
jsxLoader = true
735-
jsxLoader = true
736731
}
737732
const flatId = flattenId(id)
738733
flatIdDeps[flatId] = src
739734
idToExports[id] = exportsData
740735
}),
741736
)
742737

743-
if (optimizerContext.cancelled) return { build: undefined, idToExports }
744738
if (optimizerContext.cancelled) return { build: undefined, idToExports }
745739

746-
// In lib mode, we need to keep process.env.NODE_ENV untouched
747740
// In lib mode, we need to keep process.env.NODE_ENV untouched
748741
const define = {
749742
'process.env.NODE_ENV':
750743
isBuild && config.build.lib
751744
? 'process.env.NODE_ENV'
752745
: JSON.stringify(process.env.NODE_ENV || config.mode),
753-
'process.env.NODE_ENV':
754-
isBuild && config.build.lib
755-
? 'process.env.NODE_ENV'
756-
: JSON.stringify(process.env.NODE_ENV || config.mode),
757746
}
758747

759748
const platform =
@@ -781,35 +770,11 @@ async function prepareRolldownOptimizerRun(
781770
}
782771
}
783772

784-
const plugins = await asyncFlatten(
785-
Array.isArray(pluginsFromConfig) ? pluginsFromConfig : [pluginsFromConfig],
786-
)
787-
if (isBuild) {
788-
let rollupOptionsExternal = config?.build?.rollupOptions?.external
789-
if (rollupOptionsExternal) {
790-
if (typeof rollupOptionsExternal === 'string') {
791-
rollupOptionsExternal = [rollupOptionsExternal]
792-
}
793-
// TODO: decide whether to support RegExp and function options
794-
// They're not supported yet because `optimizeDeps.exclude` currently only accepts strings
795-
if (
796-
!Array.isArray(rollupOptionsExternal) ||
797-
rollupOptionsExternal.some((ext) => typeof ext !== 'string')
798-
) {
799-
throw new Error(
800-
`[vite] 'build.rollupOptions.external' can only be an array of strings or a string when using esbuild optimization at build time.`,
801-
)
802-
}
803-
external.push(...(rollupOptionsExternal as string[]))
804-
}
805-
}
806-
807773
const plugins = await asyncFlatten(
808774
Array.isArray(pluginsFromConfig) ? pluginsFromConfig : [pluginsFromConfig],
809775
)
810776
if (external.length) {
811777
plugins.push(rolldownCjsExternalPlugin(external, platform))
812-
plugins.push(rolldownCjsExternalPlugin(external, platform))
813778
}
814779
plugins.push(rolldownDepPlugin(flatIdDeps, external, config, ssr))
815780
plugins.push({
@@ -839,7 +804,7 @@ async function prepareRolldownOptimizerRun(
839804
async function build() {
840805
const bundle = await rolldown.rolldown({
841806
input: Object.keys(flatIdDeps),
842-
external,
807+
// external,
843808
logLevel: 'warn',
844809
plugins,
845810
resolve: {
@@ -1385,4 +1350,4 @@ const safeRename = promisify(function gracefulRename(
13851350
}
13861351
if (cb) cb(er)
13871352
})
1388-
})
1353+
})

0 commit comments

Comments
 (0)