The `esmExternalRequirePlugin` not work on rolldown-vite

[Justinidlerz]

Describe the bug

The esmExternalRequirePlugin not work on rolldown-vite, and the output behavior is not the same with rolldown.

those packages are always bundled into in rolldown-vite

Reproduction

https://stackblitz.com/edit/rolldown-rolldown-starter-stackblitz-md4wkxvw

Steps to reproduce

Run pnpm --filter app build
Run pnpm --filter app build:vite

See the dist output content

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 20.19.1 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.8.2 - /usr/local/bin/npm
    pnpm: 8.15.6 - /usr/local/bin/pnpm

Used Package Manager

pnpm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs and the Rolldown-related guide.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[ClayZzzzzth]

wooooh

[ghoullier]

I have the same issue.
Reproduction case https://github.com/ghoullier/rolldown-esm-external-require-plugin-issue

[Justinidlerz]

@shulaoda seems the vite@8.0.0-beta.2 or rolldown-vite@7.2.11 still not working, which version can I preview fixed?

[Justinidlerz]

@shulaoda seems the vite@8.0.0-beta.2 or rolldown-vite@7.2.11 still not working, which version can I preview fixed?

Sorry, I checked I have been fixed in vite@8.0.0-beta.2

[dverbru]

@shulaoda thanks for the fix. Could you please backport it to rolldown-vite?

[TheAlexLichter]

@shulaoda thanks for the fix. Could you please backport it to rolldown-vite?

any reason you can't go on Vite 8?

[dverbru]

@TheAlexLichter Yes. We have certain shared build infrastructure that uses rolldown-vite 7 and it isn't so easy to change for everybody, which also won't be prioritized while Vite 8 is still on beta.

[dverbru]

Let me put it the other way around: any reason not to fix it on the still supported rolldown-vite, where it was originally reported?

[shulaoda]

Let me put it the other way around: any reason not to fix it on the still supported rolldown-vite, where it was originally reported?

Rolldown-vite has already been merged into Vite 8 beta. All ongoing updates and fixes are now happening directly in Vite 8 beta. Functionally, there is no meaningful difference between rolldown-vite and Vite 8 beta: the former was a transitional build prior to the merge, while the latter is the continued, actively maintained version after the integration.