Open
Description
Describe the bug
When modifying files inside node_modules, the HMR doesn't work.
I guess it's because this line of code reject the following logics
https://github.com/vitejs/vite-plugin-react/blob/main/packages/plugin-react/src/index.ts#L165
async transform(code, id, options) {
if (id.includes('/node_modules/')) return
...
}
Maybe it could be simply combined with opt.include
to let those files pass.
Thanks.
Reproduction
https://github.com/Jinjiang/reproductions/tree/vite-react-hmr-202404
Steps to reproduce
pnpm install
andpnpm dev
- modify
node_modules/foo/index.mjs
to see whether the page is reloaded
System Info
System:
OS: macOS 14.4.1
CPU: (8) arm64 Apple M1
Memory: 79.17 MB / 8.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Node: 20.11.1 - ~/.local/share/mise/installs/node/20/bin/node
Yarn: 1.22.18 - ~/.yarn/bin/yarn
npm: 10.2.4 - ~/.local/share/mise/installs/node/20/bin/npm
pnpm: 8.15.5 - ~/Library/pnpm/pnpm
bun: 1.0.29 - ~/.local/share/mise/installs/bun/latest/bin/bun
Browsers:
Safari: 17.4.1
npmPackages:
@vitejs/plugin-react: ^4.2.1 => 4.2.1
vite: ^5.2.8 => 5.2.8
Used Package Manager
pnpm
Logs
No response
Validations
- Follow our Code of Conduct
- Read the Contributing Guidelines.
- Read the docs.
- Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
- Make sure this is a Vite issue and not a framework-specific issue.
- Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
- The provided reproduction is a minimal reproducible example of the bug.