Defaulting optimizeDeps.holdUntilCrawlEnd: false

[sapphi-red]

optimizeDeps.holdUntilCrawlEnd: false

• Introduced in 5.1
• Rational in Original PR
• Docs

[46tarun]

Wow

[CyberAP]

Does this work with Rolldown Vite? I get 3 page reloads on cold start.

1:08:56 AM [vite] (client) ✨ new dependencies optimized: @gitlab/application-sdk-browser, @gitlab/at.js, @gitlab/svgs/src/file_icon_map, @gleam-lang/highlight.js-gleam, @snowplow/browser-plugin-client-hints, @snowplow/browser-plugin-form-tracking, @snowplow/browser-plugin-ga-cookies, @snowplow/browser-plugin-link-click-tracking, @snowplow/browser-plugin-performance-timing, @snowplow/browser-plugin-timezone, @snowplow/browser-tracker, deckar01-task_list, dropzone, highlight.js/lib/core, highlight.js/lib/languages/1c, highlight.js/lib/languages/abnf, highlight.js/lib/languages/accesslog, highlight.js/lib/languages/actionscript, highlight.js/lib/languages/ada, highlight.js/lib/languages/angelscript, highlight.js/lib/languages/apache, highlight.js/lib/languages/applescript, highlight.js/lib/languages/arcade, highlight.js/lib/languages/arduino, highlight.js/lib/languages/armasm, highlight.js/lib/languages/asciidoc, highlight.js/lib/languages/aspectj, highlight.js/lib/languages/autohotkey, highlight.js/lib/languages/autoit, highlight.js/lib/languages/avrasm, highlight.js/lib/languages/awk, highlight.js/lib/languages/axapta, highlight.js/lib/languages/bash, highlight.js/lib/languages/basic, highlight.js/lib/languages/bnf, highlight.js/lib/languages/brainfuck, highlight.js/lib/languages/c, highlight.js/lib/languages/cal, highlight.js/lib/languages/capnproto, highlight.js/lib/languages/ceylon, highlight.js/lib/languages/clean, highlight.js/lib/languages/clojure-repl, highlight.js/lib/languages/clojure, highlight.js/lib/languages/cmake, highlight.js/lib/languages/coffeescript, highlight.js/lib/languages/coq, highlight.js/lib/languages/cos, highlight.js/lib/languages/cpp, highlight.js/lib/languages/crmsh, highlight.js/lib/languages/crystal, highlight.js/lib/languages/csharp, highlight.js/lib/languages/csp, highlight.js/lib/languages/css, highlight.js/lib/languages/d, highlight.js/lib/languages/dart, highlight.js/lib/languages/delphi, highlight.js/lib/languages/diff, highlight.js/lib/languages/django, highlight.js/lib/languages/dns, highlight.js/lib/languages/dockerfile, highlight.js/lib/languages/dos, highlight.js/lib/languages/dsconfig, highlight.js/lib/languages/dts, highlight.js/lib/languages/dust, highlight.js/lib/languages/ebnf, highlight.js/lib/languages/elixir, highlight.js/lib/languages/elm, highlight.js/lib/languages/erb, highlight.js/lib/languages/erlang-repl, highlight.js/lib/languages/erlang, highlight.js/lib/languages/excel, highlight.js/lib/languages/fix, highlight.js/lib/languages/flix, highlight.js/lib/languages/fortran, highlight.js/lib/languages/fsharp, highlight.js/lib/languages/gams, highlight.js/lib/languages/gauss, highlight.js/lib/languages/gcode, highlight.js/lib/languages/gherkin, highlight.js/lib/languages/glsl, highlight.js/lib/languages/gml, highlight.js/lib/languages/go, highlight.js/lib/languages/golo, highlight.js/lib/languages/gradle, highlight.js/lib/languages/groovy, highlight.js/lib/languages/haml, highlight.js/lib/languages/handlebars, highlight.js/lib/languages/haskell, highlight.js/lib/languages/haxe, highlight.js/lib/languages/hsp, highlight.js/lib/languages/http, highlight.js/lib/languages/hy, highlight.js/lib/languages/inform7, highlight.js/lib/languages/ini, highlight.js/lib/languages/irpf90, highlight.js/lib/languages/isbl, highlight.js/lib/languages/java, highlight.js/lib/languages/javascript, highlight.js/lib/languages/jboss-cli, highlight.js/lib/languages/json, highlight.js/lib/languages/julia-repl, highlight.js/lib/languages/julia, highlight.js/lib/languages/kotlin, highlight.js/lib/languages/lasso, highlight.js/lib/languages/latex, highlight.js/lib/languages/ldif, highlight.js/lib/languages/leaf, highlight.js/lib/languages/less, highlight.js/lib/languages/lisp, highlight.js/lib/languages/livecodeserver, highlight.js/lib/languages/livescript, highlight.js/lib/languages/llvm, highlight.js/lib/languages/lsl, highlight.js/lib/languages/lua, highlight.js/lib/languages/makefile, highlight.js/lib/languages/markdown, highlight.js/lib/languages/mathematica, highlight.js/lib/languages/matlab, highlight.js/lib/languages/maxima, highlight.js/lib/languages/mel, highlight.js/lib/languages/mercury, highlight.js/lib/languages/mipsasm, highlight.js/lib/languages/mizar, highlight.js/lib/languages/mojolicious, highlight.js/lib/languages/monkey, highlight.js/lib/languages/moonscript, highlight.js/lib/languages/n1ql, highlight.js/lib/languages/nestedtext, highlight.js/lib/languages/nginx, highlight.js/lib/languages/nim, highlight.js/lib/languages/nix, highlight.js/lib/languages/node-repl, highlight.js/lib/languages/nsis, highlight.js/lib/languages/objectivec, highlight.js/lib/languages/ocaml, highlight.js/lib/languages/openscad, highlight.js/lib/languages/oxygene, highlight.js/lib/languages/parser3, highlight.js/lib/languages/perl, highlight.js/lib/languages/pf, highlight.js/lib/languages/pgsql, highlight.js/lib/languages/php-template, highlight.js/lib/languages/php, highlight.js/lib/languages/plaintext, highlight.js/lib/languages/pony, highlight.js/lib/languages/powershell, highlight.js/lib/languages/processing, highlight.js/lib/languages/profile, highlight.js/lib/languages/prolog, highlight.js/lib/languages/properties, highlight.js/lib/languages/protobuf, highlight.js/lib/languages/puppet, highlight.js/lib/languages/purebasic, highlight.js/lib/languages/python-repl, highlight.js/lib/languages/python, highlight.js/lib/languages/q, highlight.js/lib/languages/qml, highlight.js/lib/languages/r, highlight.js/lib/languages/reasonml, highlight.js/lib/languages/rib, highlight.js/lib/languages/roboconf, highlight.js/lib/languages/routeros, highlight.js/lib/languages/rsl, highlight.js/lib/languages/ruby, highlight.js/lib/languages/ruleslanguage, highlight.js/lib/languages/rust, highlight.js/lib/languages/sas, highlight.js/lib/languages/scala, highlight.js/lib/languages/scheme, highlight.js/lib/languages/scilab, highlight.js/lib/languages/scss, highlight.js/lib/languages/shell, highlight.js/lib/languages/smali, highlight.js/lib/languages/smalltalk, highlight.js/lib/languages/sml, highlight.js/lib/languages/sqf, highlight.js/lib/languages/sql, highlight.js/lib/languages/stan, highlight.js/lib/languages/stata, highlight.js/lib/languages/step21, highlight.js/lib/languages/stylus, highlight.js/lib/languages/subunit, highlight.js/lib/languages/swift, highlight.js/lib/languages/taggerscript, highlight.js/lib/languages/tap, highlight.js/lib/languages/tcl, highlight.js/lib/languages/thrift, highlight.js/lib/languages/tp, highlight.js/lib/languages/twig, highlight.js/lib/languages/typescript, highlight.js/lib/languages/vala, highlight.js/lib/languages/vbnet, highlight.js/lib/languages/vbscript-html, highlight.js/lib/languages/vbscript, highlight.js/lib/languages/verilog, highlight.js/lib/languages/vhdl, highlight.js/lib/languages/vim, highlight.js/lib/languages/wasm, highlight.js/lib/languages/wren, highlight.js/lib/languages/x86asm, highlight.js/lib/languages/xl, highlight.js/lib/languages/xml, highlight.js/lib/languages/xquery, highlight.js/lib/languages/yaml, highlight.js/lib/languages/zephir, jquery.caret, marked-bidi, marked, micromatch, modern-screenshot, mousetrap/plugins/pause/mousetrap-pause, pinia, portal-vue, scrollparent, vue-observe-visibility, vue-resize, vue-virtual-scroll-list

1:09:00 AM [vite] (client) ✨ new dependencies optimized: canvas-confetti

1:09:07 AM [vite] (client) ✨ new dependencies optimized: @gitlab/query-language-rust, js-yaml

After each discovery I get a full page reload:

1:09:07 AM [vite] (client) ✨ optimized dependencies changed. reloading

My entrypoints are properly configured using rollupOptions.input.

With regular Vite I get just 2 page reloads. 😅

[sapphi-red]

(I noticed the title was opposite, the current default is true and changing the false is the experimental behavior.)

I think the optimizeDeps.holdUntilCrawlEnd option would work.

To clarify, optimizeDeps.holdUntilCrawlEnd: false may cause more reloads than optimizeDeps.holdUntilCrawlEnd: true.
I guess the reason why you are getting page loads are because you have those dependencies inside a dynamic imports. In other words, those dependencies are not crawled by the scanner because it's not statically imported.

In those cases, we recommend adding those late-found dependencies to optimizeDeps.include if you would like to avoid full-reloads happening in cold starts.

[CyberAP]

Thanks @sapphi-red. Turns out deps discovery was broken for me due to relative paths in the Rollup config.

build: {
          rollupOptions: {
            input: { foo: './some-relative-path' },
          },
        },

For some reason the build was working but the deps discovery was not. I could not figure this out for a while because the error message was not very prominent and also lacked important details:

2025-05-20_12:37:33.80347 vite                    : TypeError: Cannot read properties of undefined (reading 'join')
2025-05-20_12:37:33.80350 vite                    :     at file:///Users/stas/projects/gitlab-development-kit/gitlab/node_modules/vite/dist/node/chunks/dep-DBxKXgDP.js:14189:13
2025-05-20_12:37:33.80351 vite                    :     at async file:///Users/stas/projects/gitlab-development-kit/gitlab/node_modules/vite/dist/node/chunks/dep-DBxKXgDP.js:46985:28

The code it refers to:

    if (e.errors && e.message.includes("The build was canceled")) {
      return { deps: {}, missing: {} };
    }
    const prependMessage = colors$1.red(`  Failed to scan for dependencies from entries:
  ${entries.join("\n")}

I had to run a debugger for Vite to figure out it was trying out to read a relative path and failed.

I wish the message was more clear on what's gone wrong there.

[sapphi-red]

Oh, that error is definitely not expected. It’s happening inside the error handling logic itself, which is hiding the actual error.
I've opened two PR to address this - one to fix the error handling (#20079), and another to fix the resolution logic for relative paths (#20080).