Skip to content

Query buffering, terminating blocking transactions for INSTANT DDL and other "special plans" #17945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

Query buffering, terminating blocking transactions for INSTANT DDL and other "special plans" #17945

merged 1 commit into from
Apr 28, 2025

Conversation

shlomi-noach
Copy link
Contributor

@shlomi-noach shlomi-noach commented Mar 11, 2025 •
edited
Loading

Description

Fixes #17944

This PR introduces query buffering and forced query/transaction termination for special plan operations, which at this time include INSTANT DDL and range partition rotation.

  • When a migration is deemed eligible to run as a "special operation" (is instant-able and --prefer-instant-ddl strategy flag is supplied, or is found to be a range partition rotation change)
  • We now apply query buffering around the actual change
  • In addition, if --force-cut-over-duration flag is nonzero, and irrespective of its value, we also issue a one time termination for queries and transactions holding locks or metadata locks on the migrated table, just before issuing the ALTER TABLE statement.
    In the future we may also consider terminating queries/transactions while a migration is being stalled.

Related Issue(s)

#17944

Documentation: vitessio/website#1990

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@shlomi-noach shlomi-noach added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Component: schema management schemadiff and schema changes labels Mar 11, 2025
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Mar 11, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Mar 11, 2025
@shlomi-noach shlomi-noach removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Mar 11, 2025
@github-actions github-actions bot added this to the v22.0.0 milestone Mar 11, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 11, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 54 lines in your changes missing coverage. Please review.

Project coverage is 67.54%. Comparing base (0bf4276) to head (f178c99).
Report is 100 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vttablet/onlineddl/executor.go 0.00% 54 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #17945      +/-   ##
==========================================
- Coverage   67.56%   67.54%   -0.03%     
==========================================
  Files        1597     1597              
  Lines      259763   259849      +86     
==========================================
+ Hits       175506   175507       +1     
- Misses      84257    84342      +85

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shlomi-noach shlomi-noach requested a review from a team March 11, 2025 14:23
@frouioui frouioui modified the milestones: v22.0.0, v23.0.0 Apr 1, 2025
@shlomi-noach shlomi-noach requested a review from a team April 28, 2025 17:48
@shlomi-noach shlomi-noach removed the NeedsWebsiteDocsUpdate What it says label Apr 28, 2025
@shlomi-noach shlomi-noach merged commit 03a9bfe into vitessio:main Apr 28, 2025
105 of 116 checks passed
@shlomi-noach shlomi-noach deleted the onlineddl-special-direct-buffer-force branch April 28, 2025 18:09
@shlomi-noach shlomi-noach mentioned this pull request Apr 28, 2025
Open
@shlomi-noach
Copy link
Contributor Author

Documentation PR: vitessio/website#1990

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@notfelineit notfelineit Awaiting requested review from notfelineit notfelineit is a code owner

Assignees
No one assigned
Labels
Component: Online DDL Online DDL (vitess/native/gh-ost/pt-osc) Component: schema management schemadiff and schema changes Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
v23.0.0
Development

Successfully merging this pull request may close these issues.

Feature Request: query buffering, transaction termination, for "special plan" migrations such as INSTANT DDL
4 participants
@shlomi-noach @deepthi @rohit-nayak-ps @frouioui