feat: Improve promts and extend tests

Author: sveneberth

src/viur/assistant/modules/assistant.py

@@ -206,7 +206,7 @@ def translate(
                 "content": (
                     f"Translate the following text into {CONFIG.language_map.get(language, language)}"
                     f" ({". ".join(characteristics)})"
-                    f" and only return the translation, keep HTML-tags: {text}\n"
+                    f" and only return the translation, keep HTML-tags (if there are any):\n\n{text}\n"
                 )
             }],
             stop=None,
@@ -400,7 +400,7 @@ def openai_create_completion(
             message = message["answer"]
         except (JSONDecodeError, KeyError):
             raise errors.InternalServerError("Got invalid JSON from API")
-        return message.encode("utf-8").decode()  # get rid of unicode codes like \u00ea
+        return message
 
     def render_text(self, text: str) -> t.Any:
         """

tests/test_translate.py

@@ -1,16 +1,16 @@
-import os
-import pytest
 import requests
 
 BASE_URL = "http://localhost:8080/json/assistant/translate"
 
 from utils import session
 
+
 def print_response_on_error(response: requests.Response):
     if response.status_code >= 400:
         print(f"\n[HTTP ERROR] {response.status_code} {response.reason}")
         print(f"Response body:\n{response.text}\n")
-    print(f"Response body:\n{response.text}\n")
+    print(f"Response body:\n{response.json()}\n")
+
 
 def test_translate_minimal(session):
     params = {
@@ -21,6 +21,20 @@ def test_translate_minimal(session):
     print_response_on_error(response)
     assert response.status_code == 200
     assert response.text.strip()  # should contain translation
+    assert response.json().strip()  # should be JSON
+
+
+def test_translate_umlauts(session):
+    params = {
+        "text": "flowers bloom in spring.",
+        "language": "de",
+    }
+    response = session.post(BASE_URL, params=params)
+    print_response_on_error(response)
+    assert response.status_code == 200
+    assert response.text.strip()  # should contain translation
+    assert "ü" in response.json()
+
 
 def test_translate_with_characteristic(session):
     params = {
@@ -33,6 +47,7 @@ def test_translate_with_characteristic(session):
     assert response.status_code == 200
     assert response.text.strip()
 
+
 def test_translate_with_simplified(session):
     params = {
         "text": "Hallo Welt!",
@@ -44,6 +59,7 @@ def test_translate_with_simplified(session):
     assert response.status_code == 200
     assert response.text.strip()
 
+
 def test_translate_conflicting_simplified_and_characteristic(session):
     params = {
         "text": "Hallo Welt!",
@@ -55,6 +71,7 @@ def test_translate_conflicting_simplified_and_characteristic(session):
     print_response_on_error(response)
     assert response.status_code == 400  # BadRequest
 
+
 def test_translate_missing_parameters(session):
     params = {
         "language": "en"