Skip to content

Commit f954ec1

Browse files
authored
Merge pull request #3801 from vivid-planet/merge-main-into-next
Merge main into next
2 parents 204e437 + 046d6dc commit f954ec1

File tree

261 files changed

+6255
-671
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

261 files changed

+6255
-671
lines changed

.changeset/beige-comics-serve.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@comet/admin": patch
3+
---
4+
5+
Optimize responsive behavior of `CrudMoreActionsMenu`

.changeset/gentle-boats-hunt.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@comet/cms-admin": minor
3+
---
4+
5+
Adapt styling of `DamTable` to align with Comet DXP design

.changeset/hip-eagles-play.md

Lines changed: 0 additions & 5 deletions
This file was deleted.

.env

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
# node
22
NODE_ENV=development
33

4+
SERVER_HOST=localhost # change me to 0.0.0.0 if you want to access the server from other devices
5+
46
# project
57
PROJECT_NAME=comet-demo
68
DEV_DOMAIN_POSTFIX=demo

CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ Example for a good changeset:
8383

8484
````md
8585
---
86-
"@comet/cms-site": minor
86+
"@comet/site-nextjs": minor
8787
---
8888

8989
Add `ErrorHandlerProvider`
@@ -110,7 +110,7 @@ The `ErrorHandler` receives the errors in the application and can report them to
110110
```tsx
111111
"use client";
112112

113-
import { ErrorHandlerProvider } from "@comet/cms-site";
113+
import { ErrorHandlerProvider } from "@comet/site-nextjs";
114114
import { PropsWithChildren } from "react";
115115

116116
export function ErrorHandler({ children }: PropsWithChildren) {

copy-schema-files.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@ const fs = require("fs");
55
fs.promises.copyFile("packages/api/cms-api/schema.gql", "packages/admin/cms-admin/schema.gql"),
66
fs.promises.copyFile("packages/api/cms-api/block-meta.json", "packages/admin/cms-admin/block-meta.json"),
77
fs.promises.copyFile("packages/api/cms-api/block-meta.json", "packages/site/cms-site/block-meta.json"),
8+
fs.promises.copyFile("packages/api/cms-api/block-meta.json", "packages/site/site-nextjs/block-meta.json"),
9+
fs.promises.copyFile("packages/api/cms-api/block-meta.json", "packages/site/site-react/block-meta.json"),
810

911
fs.promises.copyFile("demo/api/block-meta.json", "demo/admin/block-meta.json"),
1012
fs.promises.copyFile("demo/api/block-meta.json", "demo/site/block-meta.json"),

demo/admin/package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@
1919
"lint:tsc": "tsc --project .",
2020
"preview": "npm run build && vite preview",
2121
"serve": "node server",
22-
"start": "run-s admin-generator intl:compile && run-p gql:types generate-block-types && dotenv -e .env.secrets -e .env.local -e .env -e .env.site-configs -- vite"
22+
"start": "$npm_execpath check-node-version && run-s admin-generator intl:compile && run-p gql:types generate-block-types && dotenv -e .env.secrets -e .env.local -e .env -e .env.site-configs -- vite",
23+
"check-node-version": "check-node-version --node $(cat ../../.nvmrc)"
2324
},
2425
"dependencies": {
2526
"@apollo/client": "^3.13.4",
@@ -76,6 +77,7 @@
7677
"@types/react-router": "^5.1.20",
7778
"@types/react-router-dom": "^5.3.3",
7879
"@vitejs/plugin-react-swc": "^3.8.1",
80+
"check-node-version": "^4.2.1",
7981
"chokidar-cli": "^3.0.0",
8082
"cosmiconfig-toml-loader": "^1.0.0",
8183
"dotenv-cli": "^7.4.4",

demo/admin/server/index.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ const { createProxyMiddleware } = require("http-proxy-middleware");
77

88
const app = express();
99
const port = process.env.APP_PORT ?? 3000;
10+
const host = process.env.SERVER_HOST ?? "localhost";
1011

1112
let indexFile = fs.readFileSync("./build/index.html", "utf8");
1213

@@ -38,6 +39,7 @@ app.use(
3839
);
3940

4041
app.get("/status/health", (req, res) => {
42+
res.setHeader("cache-control", "no-store");
4143
res.send("OK!");
4244
});
4345

@@ -71,6 +73,6 @@ app.get("*", (req, res) => {
7173
res.send(indexFile);
7274
});
7375

74-
app.listen(port, () => {
75-
console.log(`Admin app listening at http://localhost:${port}`);
76+
app.listen(port, host, () => {
77+
console.log(`Admin app listening at http://${host}:${port}`);
7678
});

demo/admin/vite.config.mts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ export default defineConfig(({ mode }) => {
7575
adminPackagesHotReloadPlugin,
7676
],
7777
server: {
78-
host: true,
78+
host: process.env.SERVER_HOST ?? "localhost",
7979
port: Number(process.env.ADMIN_PORT),
8080
proxy: process.env.API_URL_INTERNAL
8181
? {

demo/api/package.json

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,8 @@
2121
"lint:tsc": "tsc --project ./tsconfig.lint.json",
2222
"mikro-orm": "dotenv -e .env.secrets -e .env.local -e .env -e .env.site-configs -- mikro-orm",
2323
"start": "$npm_execpath prebuild && dotenv -e .env.secrets -e .env.local -e .env -e .env.site-configs -- nest start --debug --watch --preserveWatchOutput",
24-
"start:dev": "run-p dev:*",
24+
"check-node-version": "check-node-version --node $(cat ../../.nvmrc)",
25+
"start:dev": "$npm_execpath check-node-version && run-p dev:*",
2526
"start:prod": "node dist/main"
2627
},
2728
"dependencies": {
@@ -75,6 +76,7 @@
7576
"@types/inquirer": "^8.2.11",
7677
"@types/node": "^22.15.21",
7778
"@types/response-time": "^2.3.8",
79+
"check-node-version": "^4.2.1",
7880
"chokidar-cli": "^3.0.0",
7981
"dotenv-cli": "^7.4.4",
8082
"eslint": "^9.22.0",

0 commit comments

Comments
 (0)