Fix highlighting not updating on prefs change (#1278)

Author: vkbo

.github/workflows/test_linux.yml

@@ -25,7 +25,7 @@ jobs:
       - name: Install Packages (apt)
         run: |
           sudo apt update
-          sudo apt install libenchant-dev qttools5-dev-tools aspell-en
+          sudo apt install libenchant-2-dev qttools5-dev-tools aspell-en
       - name: Checkout Source
         uses: actions/checkout@v3
       - name: Install Dependencies (pip)

novelwriter/dialogs/preferences.py

@@ -826,6 +826,7 @@ def __init__(self, prefsGui):
         super().__init__(parent=prefsGui)
 
         self.mainConf  = novelwriter.CONFIG
+        self.prefsGui  = prefsGui
         self.mainGui   = prefsGui.mainGui
         self.mainTheme = prefsGui.mainGui.mainTheme
 
@@ -893,16 +894,21 @@ def __init__(self, prefsGui):
     def saveValues(self):
         """Save the values set for this tab.
         """
-        # Quotes & Dialogue
-        self.mainConf.highlightQuotes = self.highlightQuotes.isChecked()
-        self.mainConf.allowOpenSQuote = self.allowOpenSQuote.isChecked()
-        self.mainConf.allowOpenDQuote = self.allowOpenDQuote.isChecked()
-
-        # Text Emphasis
-        self.mainConf.highlightEmph = self.highlightEmph.isChecked()
-
-        # Text Errors
-        self.mainConf.showMultiSpaces = self.showMultiSpaces.isChecked()
+        highlightQuotes = self.highlightQuotes.isChecked()
+        allowOpenSQuote = self.allowOpenSQuote.isChecked()
+        allowOpenDQuote = self.allowOpenDQuote.isChecked()
+        highlightEmph   = self.highlightEmph.isChecked()
+        showMultiSpaces = self.showMultiSpaces.isChecked()
+
+        self.prefsGui._updateSyntax |= self.mainConf.highlightQuotes != highlightQuotes
+        self.prefsGui._updateSyntax |= self.mainConf.highlightEmph != highlightEmph
+        self.prefsGui._updateSyntax |= self.mainConf.showMultiSpaces != showMultiSpaces
+
+        self.mainConf.highlightQuotes = highlightQuotes
+        self.mainConf.allowOpenSQuote = allowOpenSQuote
+        self.mainConf.allowOpenDQuote = allowOpenDQuote
+        self.mainConf.highlightEmph   = highlightEmph
+        self.mainConf.showMultiSpaces = showMultiSpaces
 
         return