Add a shared function to translate language names

Author: vkbo

novelwriter/common.py

@@ -327,6 +327,11 @@ def processLangCode(code: str) -> str:
     return QLocale(code).name().replace("_", "-") if code else ""
 
 
+def languageName(code: str) -> str:
+    """Return the local name of a language."""
+    return QLocale(code).nativeLanguageName().title()
+
+
 def elide(text: str, length: int) -> str:
     """Elide a piece of text to a maximum length."""
     if len(text) > (cut := max(4, length)):

novelwriter/config.py

@@ -43,7 +43,7 @@
 
 from novelwriter.common import (
     NWConfigParser, checkInt, checkPath, describeFont, fontMatcher,
-    formatTimeStamp, joinLines, processDialogSymbols, simplified
+    formatTimeStamp, joinLines, languageName, processDialogSymbols, simplified
 )
 from novelwriter.constants import nwFiles, nwQuotes, nwUnicode
 from novelwriter.enum import nwTheme
@@ -507,11 +507,11 @@ def listLanguages(self, lngSet: int) -> list[tuple[str, str]]:
         if lngSet == self.LANG_NW:
             fPre = "nw_"
             fExt = ".qm"
-            langList = {"en_GB": QLocale("en_GB").nativeLanguageName().title()}
+            langList = {"en_GB": languageName("en_GB")}
         elif lngSet == self.LANG_PROJ:
             fPre = "project_"
             fExt = ".json"
-            langList = {"en_GB": QLocale("en_GB").nativeLanguageName().title()}
+            langList = {"en_GB": languageName("en_GB")}
         else:
             return []
 
@@ -521,7 +521,7 @@ def listLanguages(self, lngSet: int) -> list[tuple[str, str]]:
                 continue
 
             qmLang = qmName[len(fPre):-len(fExt)]
-            qmName = QLocale(qmLang).nativeLanguageName().title()
+            qmName = languageName(qmLang)
             if qmLang and qmName and qmLang != "en_GB":
                 langList[qmLang] = qmName
 

novelwriter/core/spellcheck.py

@@ -30,8 +30,7 @@
 from pathlib import Path
 from typing import TYPE_CHECKING
 
-from PyQt6.QtCore import QLocale
-
+from novelwriter.common import languageName
 from novelwriter.constants import nwFiles
 from novelwriter.error import logException
 
@@ -139,7 +138,7 @@ def listDictionaries(self) -> list[tuple[str, str]]:
         try:
             import enchant
             tags = [x for x, _ in enchant.list_dicts()]
-            lang = [(x, f"{QLocale(x).nativeLanguageName().title()} [{x}]") for x in set(tags)]
+            lang = [(x, f"{languageName(x)} [{x}]") for x in set(tags)]
         except Exception:
             logger.error("Failed to list languages for enchant spell checking")
         return sorted(lang, key=lambda x: x[1])

novelwriter/gui/statusbar.py

@@ -28,11 +28,11 @@
 from datetime import datetime
 from time import time
 
-from PyQt6.QtCore import QLocale, pyqtSlot
+from PyQt6.QtCore import pyqtSlot
 from PyQt6.QtWidgets import QApplication, QLabel, QStatusBar, QWidget
 
 from novelwriter import CONFIG, SHARED
-from novelwriter.common import formatTime
+from novelwriter.common import formatTime, languageName
 from novelwriter.constants import nwConst, nwLabels, nwStats, trStats
 from novelwriter.extensions.modified import NClickableLabel
 from novelwriter.extensions.statusled import StatusLED
@@ -208,7 +208,7 @@ def setLanguage(self, language: str, provider: str) -> None:
             self.langText.setText(self.tr("None"))
             self.langText.setToolTip("")
         else:
-            self.langText.setText(QLocale(language).nativeLanguageName().title())
+            self.langText.setText(languageName(language))
             self.langText.setToolTip(f"{language} ({provider})" if provider else language)
 
     @pyqtSlot(bool)

novelwriter/tools/manussettings.py

@@ -27,7 +27,7 @@
 
 from typing import TYPE_CHECKING
 
-from PyQt6.QtCore import QEvent, QLocale, pyqtSignal, pyqtSlot
+from PyQt6.QtCore import QEvent, pyqtSignal, pyqtSlot
 from PyQt6.QtGui import QFont, QIcon, QSyntaxHighlighter, QTextCharFormat, QTextDocument
 from PyQt6.QtWidgets import (
     QAbstractButton, QAbstractItemView, QDialogButtonBox, QFrame, QGridLayout,
@@ -37,7 +37,10 @@
 )
 
 from novelwriter import CONFIG, SHARED
-from novelwriter.common import describeFont, fontMatcher, processLangCode, qtAddAction, qtLambda
+from novelwriter.common import (
+    describeFont, fontMatcher, languageName, processLangCode, qtAddAction,
+    qtLambda
+)
 from novelwriter.constants import nwHeadFmt, nwKeyWords, nwLabels, nwUnicode, trConst
 from novelwriter.core.buildsettings import BuildSettings, FilterMode
 from novelwriter.enum import nwStandardButton
@@ -1633,7 +1636,7 @@ def _resetPageHeader(self) -> None:
     def _refreshMetaLang(self) -> None:
         """Update the meta language helper info."""
         code = self.metaLanguage.text().strip()
-        self.lblMetaLanguage.setText(QLocale(code).nativeLanguageName().title())
+        self.lblMetaLanguage.setText(languageName(code))
 
     ##
     #  Internal Functions

tests/test_base/test_base_common.py

@@ -37,10 +37,10 @@
     fontMatcher, formatFileFilter, formatInt, formatTime, formatTimeStamp,
     formatVersion, fuzzyTime, getFileSize, hexToInt, isHandle, isItemClass,
     isItemLayout, isItemType, isListInstance, isTitleTag, joinLines,
-    jsonCombine, jsonEncode, makeFileNameSafe, minmax, numberToRoman,
-    openExternalPath, processDialogSymbols, readTextFile, simplified,
-    transferCase, uniqueCompact, utf16CharMap, xmlElement, xmlIndent,
-    xmlSubElem, yesNo
+    jsonCombine, jsonEncode, languageName, makeFileNameSafe, minmax,
+    numberToRoman, openExternalPath, processDialogSymbols, processLangCode,
+    readTextFile, simplified, transferCase, uniqueCompact, utf16CharMap,
+    xmlElement, xmlIndent, xmlSubElem, yesNo
 )
 from novelwriter.enum import nwItemClass
 
@@ -411,6 +411,21 @@ def testBaseCommon_processDialogSymbols():
     assert processDialogSymbols("-\u2013\u2014\u2015") == "\u2013\u2014\u2015"
 
 
+@pytest.mark.base
+def testBaseCommon_processLangCode():
+    """Test the processLangCode function."""
+    assert processLangCode("") == ""
+    assert processLangCode(" ") == ""
+    assert processLangCode("en") == "en-US"
+    assert processLangCode("en_gb") == "en-GB"
+
+
+@pytest.mark.base
+def testBaseCommon_languageName():
+    """Test the languageName function."""
+    assert languageName("en-GB") == "British English"
+
+
 @pytest.mark.base
 def testBaseCommon_elide():
     """Test the elide function."""