meta: Enable -Wpedantic

I'd like to aim for POSIX C99 compatibility with this project. There are
only two places where -Wpedantic was still warning about things.
In sdl.c, it didn't like assigning (void *) to function pointers, but
the whole dynamic sdl2 implementation depends on that, so I disabled the
diagnostic for a small region in try_get_sdl2_syms() there.
The rest were a few warnings in transforms.c, resolved by removing a few
const qualifiers.

Author: vkoskiv

CMakeLists.txt

@@ -34,8 +34,7 @@ if (MSVC)
 	set(CMAKE_EXE_LINKER_FLAGS_DEBUG   "/DEBUG /MANIFEST:NO" CACHE STRING "" FORCE)
 	set(CMAKE_EXE_LINKER_FLAGS_RELEASE "/DEBUG /MANIFEST:NO /INCREMENTAL:NO /OPT:REF,ICF" CACHE STRING "" FORCE)
 else()
-	# set(CMAKE_C_FLAGS "-Wall -Wextra -pedantic -Wconversion -std=gnu99")
-	set(CMAKE_C_FLAGS "-Wall -Wextra -Wno-missing-field-initializers -std=c99 -D_POSIX_C_SOURCE=200112L")
+	set(CMAKE_C_FLAGS "-Wall -Wextra -Wpedantic -Wno-missing-field-initializers -std=c99 -D_POSIX_C_SOURCE=200112L")
 	set(CMAKE_C_FLAGS_RELEASE "-O2 -ftree-vectorize -g")
 	set(CMAKE_C_FLAGS_DEBUG "${CMAKE_C_FLAGS_DEBUG} -O0 -g")
 	if (ASAN)

Makefile

@@ -2,7 +2,7 @@ MAKEFLAGS += --no-builtin-rules
 CC?=cc
 -include ccache.mk
 OPT?=-O2
-CFLAGS=-I./include/ -I./src/ -Wall -Wextra -Wno-missing-field-initializers -std=c99 -D_POSIX_C_SOURCE=200112L $(OPT) -g -ftree-vectorize
+CFLAGS=-I./include/ -I./src/ -Wall -Wextra -Wpedantic -Wno-missing-field-initializers -std=c99 -D_POSIX_C_SOURCE=200112L $(OPT) -g -ftree-vectorize
 LDLIBS=-lpthread -lm -ldl
 
 BINDIR=bin

src/common/logging.c

@@ -64,7 +64,7 @@ static void printPrefix(enum logType type) {
 	}
 }
 
-static void printDate() {
+static void printDate(void) {
 	const time_t curTime = time(NULL);
 	struct tm *time = localtime(&curTime);
 	printf("[%d-%02d-%02d %02d:%02d:%02d] ",

src/common/platform/capabilities.c

@@ -20,7 +20,7 @@ typedef unsigned short u_short;
 #include <unistd.h>
 #endif
 
-int sys_get_cores() {
+int sys_get_cores(void) {
 #ifdef __APPLE__
 	int nm[2];
 	size_t len = 4;

src/common/platform/mutex.c

@@ -9,7 +9,7 @@
 #include "mutex.h"
 #include <stdlib.h>
 
-struct cr_mutex *mutex_create() {
+struct cr_mutex *mutex_create(void) {
 	struct cr_mutex *new = calloc(1, sizeof(*new));
 #ifdef WINDOWS
 	InitializeCriticalSection(&new->lock);

src/common/transforms.c

@@ -184,7 +184,7 @@ struct transform tform_new_scale(float scale) {
 	return transform;
 }
 
-static void getCofactor(const float A[4][4], float cofactors[4][4], int p, int q, int n) {
+static void getCofactor(/*const*/ float A[4][4], float cofactors[4][4], int p, int q, int n) {
 	int i = 0;
 	int j = 0;
 
@@ -203,7 +203,7 @@ static void getCofactor(const float A[4][4], float cofactors[4][4], int p, int q
 
 //I really, really hope this is faster than the generic one
 //I wrote this by hand...
-float findDeterminant4x4(const float A[4][4]) {
+float findDeterminant4x4(/*const*/ float A[4][4]) {
 	float topLeft = A[0][0] * ((A[1][1] * ((A[2][2]*A[3][3])-(A[2][3]*A[3][2]))) - (A[1][2] * ((A[2][1]*A[3][3])-(A[2][3]*A[3][1]))) + (A[1][3] * ((A[2][1]*A[3][2])-(A[2][2]*A[3][1]))));
 	float topRigh = A[0][1] * ((A[1][0] * ((A[2][2]*A[3][3])-(A[2][3]*A[3][2]))) - (A[1][2] * ((A[2][0]*A[3][3])-(A[2][3]*A[3][0]))) + (A[1][3] * ((A[2][0]*A[3][2])-(A[2][2]*A[3][0]))));
 	float botLeft = A[0][2] * ((A[1][0] * ((A[2][1]*A[3][3])-(A[2][3]*A[3][1]))) - (A[1][1] * ((A[2][0]*A[3][3])-(A[2][3]*A[3][0]))) + (A[1][3] * ((A[2][0]*A[3][1])-(A[2][1]*A[3][0]))));
@@ -212,7 +212,7 @@ float findDeterminant4x4(const float A[4][4]) {
 }
 
 //Find det of a given 4x4 matrix A
-float findDeterminant(const float A[4][4], int n) {
+float findDeterminant(/*const*/ float A[4][4], int n) {
 	float det = 0.0f;
 
 	if (n == 1)
@@ -230,7 +230,7 @@ float findDeterminant(const float A[4][4], int n) {
 	return det;
 }
 
-static void findAdjoint(const float A[4][4], float adjoint[4][4]) {
+static void findAdjoint(/*const*/ float A[4][4], float adjoint[4][4]) {
 	int sign = 1;
 	float temp[4][4];
 

src/driver/sdl.c

@@ -75,6 +75,12 @@ static struct sdl_syms *try_get_sdl2_syms(void) {
 	void *sdl2 = try_find_sdl2_lib();
 	if (!sdl2) return NULL;
 	struct sdl_syms *syms = calloc(1, sizeof(*syms));
+	/*
+		warning: ISO C forbids initialization between function pointer and ‘void *’ [-Wpedantic]
+			=> We don't care about this in $CURRENT_YEAR :]
+	*/
+	#pragma GCC diagnostic ignored "-Wpedantic"
+	#pragma GCC diagnostic push
 	*syms = (struct sdl_syms){
 		.lib = sdl2,
 		.SDL_VideoInit              = dyn_sym(sdl2, "SDL_VideoInit"),
@@ -99,6 +105,7 @@ static struct sdl_syms *try_get_sdl2_syms(void) {
 		.SDL_UpdateTexture          = dyn_sym(sdl2, "SDL_UpdateTexture"),
 		.SDL_RenderCopy             = dyn_sym(sdl2, "SDL_RenderCopy")
 	};
+	#pragma GCC diagnostic pop
 	for (size_t i = 0; i < (sizeof(struct sdl_syms) / sizeof(void *)); ++i) {
 		if (!((void **)syms)[i]) {
 			logr(warning, "sdl_syms[%zu] is NULL\n", i);

src/lib/accelerators/bvh.c

@@ -150,7 +150,7 @@ static inline struct bvh_index make_inner_index(size_t first_child) {
 	};
 }
 
-static inline struct split make_invalid_split() {
+static inline struct split make_invalid_split(void) {
 	return (struct split) {
 		.axis = -1,
 		.pos = 0,
@@ -162,7 +162,7 @@ static inline bool is_valid_split(const struct split *split) {
 	return split->axis <= 2;
 }
 
-static inline struct bin make_empty_bin() {
+static inline struct bin make_empty_bin(void) {
 	return (struct bin) {
 		.bbox = emptyBBox,
 		.count = 0

src/lib/api/c-ray.c

@@ -39,11 +39,11 @@
 
 #define VERSION "0.6.3"DEBUG
 
-char *cr_get_version() {
+char *cr_get_version(void) {
 	return VERSION;
 }
 
-char *cr_get_git_hash() {
+char *cr_get_git_hash(void) {
 	return gitHash();
 }
 
@@ -53,7 +53,7 @@ struct cr_shader_node *shader_deepcopy(const struct cr_shader_node *in);
 
 struct cr_renderer;
 
-struct cr_renderer *cr_new_renderer() {
+struct cr_renderer *cr_new_renderer(void) {
 	return (struct cr_renderer *)renderer_new();
 }
 

src/lib/protocol/server.c

@@ -47,7 +47,7 @@ void client_drop(struct render_client *client) {
 	client->status = Disconnected;
 }
 
-static cJSON *make_handshake() {
+static cJSON *make_handshake(void) {
 	cJSON *handshake = cJSON_CreateObject();
 	cJSON_AddStringToObject(handshake, "action", "handshake");
 	cJSON_AddStringToObject(handshake, "version", PROTO_VERSION);

src/lib/protocol/worker.c

@@ -355,7 +355,7 @@ static cJSON *processCommand(int connectionSocket, cJSON *json, size_t thread_li
 	ASSERT_NOT_REACHED();
 }
 
-static void workerCleanup() {
+static void workerCleanup(void) {
 	if (!g_worker_renderer) return;
 	renderer_destroy(g_worker_renderer);
 	g_worker_renderer = NULL;

src/lib/renderer/samplers/sampler.c

@@ -23,7 +23,7 @@ struct sampler {
 	} sampler;
 };
 
-struct sampler *newSampler() {
+struct sampler *newSampler(void) {
 	return calloc(1, sizeof(struct sampler));
 }
 

src/lib/vendored/pcg_basic.c

@@ -67,7 +67,7 @@ uint32_t pcg32_random_r(pcg32_random_t* rng)
     return (xorshifted >> rot) | (xorshifted << ((-rot) & 31));
 }
 
-uint32_t pcg32_random()
+uint32_t pcg32_random(void)
 {
     return pcg32_random_r(&pcg32_global);
 }