refactor: Reimplement the API interface

* Discarded generic Fitler in favor of iBloomFilter
* Fix the Murmur2 algorithm
* Optimize the batch API interface

Author: vla

src/BloomFilter.Redis/FilterRedis.T.cs

@@ -1,4 +1,5 @@
-using System.Collections.Generic;
+using System;
+using System.Collections.Generic;
 using System.Linq;
 using System.Threading.Tasks;
 
@@ -9,6 +10,7 @@ namespace BloomFilter.Redis
     /// </summary>
     /// <typeparam name="T"></typeparam>
     /// <seealso cref="Filter{T}" />
+    [Obsolete("Use non-generic FilterRedis")]
     public class FilterRedis<T> : Filter<T>
     {
         private readonly IRedisBitOperate _redisBitOperate;
@@ -63,17 +65,12 @@ public override async Task<bool> AddAsync(byte[] element)
             return results.Any(a => !a);
         }
 
-        /// <summary>
-        /// Adds the specified elements.
-        /// </summary>
-        /// <param name="elements">The elements.</param>
-        /// <returns></returns>
-        public override IList<bool> Add(IEnumerable<T> elements)
+        public override IList<bool> Add(IEnumerable<byte[]> elements)
         {
             var addHashs = new List<int>();
             foreach (var element in elements)
             {
-                addHashs.AddRange(ComputeHash(ToBytes(element)));
+                addHashs.AddRange(ComputeHash(element));
             }
 
             IList<bool> results = new List<bool>();
@@ -95,12 +92,12 @@ public override IList<bool> Add(IEnumerable<T> elements)
             return results;
         }
 
-        public override async Task<IList<bool>> AddAsync(IEnumerable<T> elements)
+        public async override Task<IList<bool>> AddAsync(IEnumerable<byte[]> elements)
         {
             var addHashs = new List<int>();
             foreach (var element in elements)
             {
-                addHashs.AddRange(ComputeHash(ToBytes(element)));
+                addHashs.AddRange(ComputeHash(element));
             }
 
             IList<bool> results = new List<bool>();
@@ -122,19 +119,6 @@ public override async Task<IList<bool>> AddAsync(IEnumerable<T> elements)
             return results;
         }
 
-        /// <summary>
-        /// Removes all elements from the filter
-        /// </summary>
-        public override void Clear()
-        {
-            _redisBitOperate.Clear(_name);
-        }
-
-        public override Task ClearAsync()
-        {
-            return _redisBitOperate.ClearAsync(_name);
-        }
-
         /// <summary>
         /// Tests whether an element is present in the filter
         /// </summary>
@@ -158,17 +142,12 @@ public override async Task<bool> ContainsAsync(byte[] element)
             return results.All(a => a);
         }
 
-        /// <summary>
-        /// Tests whether an elements is present in the filter
-        /// </summary>
-        /// <param name="elements"></param>
-        /// <returns></returns>
-        public override IList<bool> Contains(IEnumerable<T> elements)
+        public override IList<bool> Contains(IEnumerable<byte[]> elements)
         {
             var addHashs = new List<int>();
             foreach (var element in elements)
             {
-                addHashs.AddRange(ComputeHash(ToBytes(element)));
+                addHashs.AddRange(ComputeHash(element));
             }
 
             IList<bool> results = new List<bool>();
@@ -190,12 +169,12 @@ public override IList<bool> Contains(IEnumerable<T> elements)
             return results;
         }
 
-        public override async Task<IList<bool>> ContainsAsync(IEnumerable<T> elements)
+        public async override Task<IList<bool>> ContainsAsync(IEnumerable<byte[]> elements)
         {
             var addHashs = new List<int>();
             foreach (var element in elements)
             {
-                addHashs.AddRange(ComputeHash(ToBytes(element)));
+                addHashs.AddRange(ComputeHash(element));
             }
 
             IList<bool> results = new List<bool>();
@@ -217,6 +196,29 @@ public override async Task<IList<bool>> ContainsAsync(IEnumerable<T> elements)
             return results;
         }
 
+        public override bool All(IEnumerable<byte[]> elements)
+        {
+            return Contains(elements).All(e => e);
+        }
+
+        public async override Task<bool> AllAsync(IEnumerable<byte[]> elements)
+        {
+            return (await ContainsAsync(elements)).All(e => e);
+        }
+
+        /// <summary>
+        /// Removes all elements from the filter
+        /// </summary>
+        public override void Clear()
+        {
+            _redisBitOperate.Clear(_name);
+        }
+
+        public override Task ClearAsync()
+        {
+            return _redisBitOperate.ClearAsync(_name);
+        }
+
         public override void Dispose()
         {
             _redisBitOperate.Dispose();

src/BloomFilter.Redis/FilterRedis.cs

@@ -3,7 +3,9 @@
     /// <summary>
     /// Bloom Filter Redis Implement
     /// </summary>
+#pragma warning disable CS0618
     public class FilterRedis : FilterRedis<byte[]>
+#pragma warning restore CS0618
     {
         /// <summary>
         /// Initializes a new instance of the <see cref="FilterRedis"/> class.