Plugins on_begin_pass / on_end_pass not called?

[apekros]

I have noticed strange behaviour related to label selection (https://docs.rs/egui/latest/egui/text_selection/struct.LabelSelectionState.html), it seems as if the egui plugins don't get called resulting in strange selection behaviour

[vladbat00]

Hi! Could you please expand a bit on the strange behaviour you are seeing? I'm not sure what kind of problem I should look for. And some code to reproduce the issue would also help (unless you are observing that in the repo examples as well).

[apekros]

Hi! Could you please expand a bit on the strange behaviour you are seeing? I'm not sure what kind of problem I should look for. And some code to reproduce the issue would also help (unless you are observing that in the repo examples as well).

When I have a selectable label, and drag across it in a Window to select, it triggers the initial select but never deselects, this seems to have only been introduced for me since egui added Plugins.

[vladbat00]

Am I understanding it correctly that the issue you are describing is not just about plugins not getting called, but about visual behaviour of the widgets? Cause I don't think I can reproduce it. This is the behaviour I'm getting in the simple example:

1. Click the mouse button and drag the cursor over the "world" label to select some text (result: the selection appears).
2. Release the mouse button (result: the selection is still there).
3. Click anywhere on the screen again (result: the selection disappears).

Are you seeing/expecting some different selection behaviour? Or are you describing a different scenario?

[apekros]

Am I understanding it correctly that the issue you are describing is not just about plugins not getting called, but about visual behaviour of the widgets? Cause I don't think I can reproduce it. This is the behaviour I'm getting in the simple example:

1. Click the mouse button and drag the cursor over the "world" label to select some text (result: the selection appears).
2. Release the mouse button (result: the selection is still there).
3. Click anywhere on the screen again (result: the selection disappears).

Are you seeing/expecting some different selection behaviour? Or are you describing a different scenario?

For more context for this, it was because of behaviour on our fork, apologies about this. It's due to the plugin behaviour introduced in egui 0.34

We worked around this by calling the Plugins on begin pass / on end pass ourselves