Skip to content

Great library, a few ideas #1

@aasaru

Description

@aasaru

Hi!

Great work!

A few ideas for improvement.

  • have as few dependencies as possible (get rid of Lombok - I'm maintaining a library that does not have Lombok and if I would add a dependency on your library it would mean my library has to depend on Lombok)
  • also consider adding support other countries like Lithuania (they have same id-code system as Estonia) and Latvia (beware that newer Latvian id-codes don't have birthdate in them)
  • make separate classes for parsing idCode, generating idCode and validating idCode - just for clarity and to separate use cases.

Cheers!
Juhan

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions