finding libgc.a issue

[chenrui333]

Describe the bug

I am trying to upgrade vlang to use the latest release, 0.3.2, but run into the following runtime failure

$ /opt/homebrew/Cellar/vlang/0.3.2/bin/v doctor
cannot compile `/opt/homebrew/Cellar/vlang/0.3.2/libexec/cmd/tools/vdoctor.v`:
clang: error: no such file or directory: '/opt/homebrew/Cellar/vlang/0.3.2/libexec/thirdparty/tcc/lib/libgc.a'
builder error:

Side NOTE, we dont have tcc available for OSX due to the reason it is no longer supported for Big Sur and above (i.e. macos-11+), http://savannah.nongnu.org/bugs/?59640

Expected Behavior

The libgc.a is right in here.

$ fd libgc.a /opt/homebrew/lib
/opt/homebrew/lib/libgc.a

$ fd libgc.a /opt/homebrew/Cellar/
/opt/homebrew/Cellar/bdw-gc/8.2.2/lib/libgc.a

Current Behavior

==> /opt/homebrew/Cellar/vlang/0.3.2/bin/v -o test hello_world.v
Last 15 lines from /Users/rui/Library/Logs/Homebrew/vlang/test.01.v:
clang: error: no such file or directory: '/opt/homebrew/Cellar/vlang/0.3.2/libexec/thirdparty/tcc/lib/libgc.a'

Reproduction Steps

• wget https://raw.githubusercontent.com/Homebrew/homebrew-core/b45ed0fc87e04958714b114103443da4d1452c62/Formula/vlang.rb -O vlang.rb
• brew reinstall -s vlang.rb
• brew test -v vlang

Possible Solution

No response

Additional Information/Context

No response

V version

0.3.2

Environment details (OS name and version, etc.)

$ brew config
HOMEBREW_VERSION: 3.6.16-8-g895d322
ORIGIN: https://github.com/Homebrew/brew
HEAD: 895d3221215dff340baa3fc58b114ce5c52c52d1
Last commit: 4 days ago
Core tap ORIGIN: https://github.com/Homebrew/homebrew-core
Core tap HEAD: 03eed2f0ec12aef980ed1b74d1a28c0093c23204
Core tap last commit: 35 minutes ago
Core tap branch: bump-vlang-0.3.2
HOMEBREW_PREFIX: /opt/homebrew
HOMEBREW_CASK_OPTS: []
HOMEBREW_EDITOR: vim
HOMEBREW_GITHUB_API_TOKEN: set
HOMEBREW_MAKE_JOBS: 10
HOMEBREW_NO_AUTO_UPDATE: set
Homebrew Ruby: 2.6.10 => /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/bin/ruby
CPU: 10-core 64-bit arm_firestorm_icestorm
Clang: 14.0.0 build 1400
Git: 2.39.0 => /opt/homebrew/bin/git
Curl: 7.85.0 => /usr/bin/curl
macOS: 13.1-arm64
CLT: 14.2.0.0.1.1668646533
Xcode: 14.2
Rosetta 2: false

[harens]

I patched this in the MacPorts weekly build here. It's just a matter of replacing some of the hardcoded paths.

--- vlib/builtin/builtin_d_gcboehm.c.v.original	2022-11-10 11:57:53.000000000 +0000
+++ vlib/builtin/builtin_d_gcboehm.c.v	2022-11-10 16:02:13.000000000 +0000
@@ -31,12 +31,12 @@
 } $else {
 	$if macos || linux {
 		#flag -DGC_BUILTIN_ATOMIC=1
-		#flag -I @VEXEROOT/thirdparty/libgc/include
-		$if (prod && !tinyc && !debug) || !(amd64 || arm64 || i386 || arm32) {
+		#flag -I @PREFIX@/include
+		$if (!macos && prod && !tinyc && !debug) || !(amd64 || arm64 || i386 || arm32) {
 			// TODO: replace the architecture check with a `!$exists("@VEXEROOT/thirdparty/tcc/lib/libgc.a")` comptime call
 			#flag @VEXEROOT/thirdparty/libgc/gc.o
 		} $else {
-			#flag @VEXEROOT/thirdparty/tcc/lib/libgc.a
+			#flag @PREFIX@/lib/libgc.a
 		}
 		$if macos {
 			#flag -DMPROTECT_VDB=1

[spytheman]

What expands @PREFIX@ ?
That is not a V construct 🤔 ... Does MacPorts expand it somehow?

[harens]

Forgot to mention that :) Yes, the MacPorts portfile expands it to whatever prefix the user is currently using.

[chenrui333]

Let me try that fix. Thanks @harens!! :)

[chenrui333]

Yeah, that patch works, can we file a PR to make it @PREFIX@ into the repo?

to @spytheman, yeah, that is package manager DEFINE :) (for me, I have to replace that with Formula["bdw-gc"].opt_prefix)

[Delta456]

Why don't you make a PR for this then?

[spytheman]

Yeah, that patch works, can we file a PR to make it @Prefix@ into the repo?

@PREFIX@ is not expanded by V. The patch is for MacPorts and other systems do not need it.

[spytheman]

V supports linking to the system Boehm library, assuming it has a pkg-config file, with:
-d dynamic_boehm :

[chenrui333]

I think we can PR for that change (make it some overridable include).

Also, tcc is no longer maintained and does not build on macos big sur and above.

[JalonSolov]

I think you may need to check your facts... the latest commit to tcc was done 12 hours ago.

If there's a version that was installed with the OS, then yes, that is likely very far out of date. V, however, installs a very much later version of tcc under the thirdparty dir, and that is what it uses.

[chenrui333]

I think you may need to check your facts... the latest commit to tcc was done 12 hours ago.

sorry, where can I find the latest tcc?

[chenrui333]

If there's a version that was installed with the OS, then yes, that is likely very far out of date. V, however, installs a very much later version of tcc under the thirdparty dir, and that is what it uses.

I see your point, I believe that is where it might be an issue. Not sure how MacPort folks think about this.

When I said it is no longer maintained, I mostly refer to the main repo, https://github.com/LuaDist/tcc

And the repology basically said about the same thing, https://repology.org/project/tcc/packages