[Bug]: broken binary search in GetSignature func (#1993)

Signed-off-by: Omer Aplatony <omerap12@gmail.com>

Author: omerap12

pkg/cache/model_gpu_profile.go

@@ -135,8 +135,8 @@ func (pf *ModelGPUProfile) GetSignature(features ...float64) ([]int, error) {
 				} else {
 					ret[i] = mid
 					found = true
+					break
 				}
-				break
 			}
 			if !found {
 				if value < indexes[i][left]+(indexes[i][right]-indexes[i][left])*SignatureTolerance {

pkg/cache/model_gpu_profile_test.go

@@ -43,4 +43,22 @@ var _ = Describe("ModelGPUProfile", func() {
 		Expect(err).To(BeNil())
 		Expect(signatures).To(Equal([]int{0, 4}))
 	})
+
+	It("should GetSignature find exact match in the middle of a large index", func() {
+		signatures, err := profile.GetSignature(64, 256)
+		Expect(err).To(BeNil())
+		Expect(signatures).To(Equal([]int{4, 1}))
+	})
+
+	It("should GetSignature find value near the end of a large index", func() {
+		signatures, err := profile.GetSignature(256, 128)
+		Expect(err).To(BeNil())
+		Expect(signatures).To(Equal([]int{6, 0}))
+	})
+
+	It("should GetSignature find value near the start of a large index", func() {
+		signatures, err := profile.GetSignature(8, 128)
+		Expect(err).To(BeNil())
+		Expect(signatures).To(Equal([]int{1, 0}))
+	})
 })