Skip to content

Commit 55e8294

Browse files
committed
test
Signed-off-by: Zhewen Li <zhewenli@meta.com>
1 parent 4d22056 commit 55e8294

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

buildkite/test-template-ci.j2

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -780,9 +780,9 @@ steps:
780780
echo "Step '{{ step.label }}' (key: $$STEP_KEY): $$OUTCOME"
781781
if [ "$$OUTCOME" != "passed" ] && [ "$$OUTCOME" != "unknown" ]; then
782782
if [ -z "$$FAILED_TESTS" ]; then
783-
FAILED_TESTS="- {{ step.label }} ($$OUTCOME)"
783+
FAILED_TESTS="{{ step.label }} ($$OUTCOME)"
784784
else
785-
FAILED_TESTS="$$FAILED_TESTS\n- {{ step.label }} ($$OUTCOME)"
785+
FAILED_TESTS="$$FAILED_TESTS, {{ step.label }} ($$OUTCOME)"
786786
fi
787787
TOTAL_FAILED=$$((TOTAL_FAILED + 1))
788788
fi
@@ -795,9 +795,6 @@ steps:
795795
if [ -n "$$FAILED_TESTS" ]; then
796796
echo "Failed tests found, uploading notification step..."
797797

798-
# Convert \n to actual newlines for the Slack message
799-
FAILED_TESTS_FORMATTED=$$(printf '%b' "$$FAILED_TESTS")
800-
801798
cat <<- YAML | buildkite-agent pipeline upload
802799
steps:
803800
- label: ":slack: Notify about nightly test failures"
@@ -806,16 +803,15 @@ steps:
806803
queue: small_cpu_queue_premerge
807804
command: |
808805
echo "Nightly tests failed ($$TOTAL_FAILED/$$TOTAL_CHECKED):"
809-
printf '%b\n' "$$FAILED_TESTS"
806+
echo "$$FAILED_TESTS"
810807
notify:
811808
- slack:
812809
channels:
813810
- "vllm#buildkite-notifications"
814811
message: |
815812
:rotating_light: Nightly Tests Failed ($$TOTAL_FAILED/$$TOTAL_CHECKED)
816813

817-
Failed tests:
818-
$$FAILED_TESTS_FORMATTED
814+
Failed tests: $$FAILED_TESTS
819815

820816
Build: <$${BUILDKITE_BUILD_URL}|#$${BUILDKITE_BUILD_NUMBER}>
821817
YAML

0 commit comments

Comments
 (0)