[Feat] implement ModelEvaluator for automated onboarding flow (#1153)#1275
Draft
aby42 wants to merge 3 commits intovllm-project:mainfrom
Draft
[Feat] implement ModelEvaluator for automated onboarding flow (#1153)#1275aby42 wants to merge 3 commits intovllm-project:mainfrom
aby42 wants to merge 3 commits intovllm-project:mainfrom
Conversation
Signed-off-by: aby42 <255879930+aby42@users.noreply.github.com>
Signed-off-by: aby42 <255879930+aby42@users.noreply.github.com>
✅ Deploy Preview for vllm-semantic-router ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the initial ModelEvaluator (OnboardEvaluate) as the first milestone for the model onboarding procedure.
To keep the discussion centralized, I have posted the detailed architectural plan, roadmap, and sample JSON output directly in the issue comments.
Please refer to the discussion here: #1153 (comment)
Key Changes
Added
src/training/model_eval/onboard_eval.pywith core benchmarking logic.Supported reasoning (ARC, MMLU-Pro) and performance metrics tracking.
This is a Draft PR intended for early architectural review of the code structure.
FIX #1153
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
-swhen doinggit commit[Bugfix],[Feat], and[CI].Detailed Checklist (Click to Expand)
Thank you for your contribution to semantic-router! Before submitting the pull request, please ensure the PR meets the following criteria. This helps us maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Please try to classify PRs for easy understanding of the type of changes. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]for bug fixes.[CI/Build]for build or continuous integration improvements.[CLI]for changes to the command-line interface tools.[Dashboard]for changes to the dashboard or web UI.[Doc]for documentation fixes and improvements.[Feat]for new features in the cluster (e.g., autoscaling, disaggregated prefill, etc.).[Router]for changes to thevllm_router(e.g., routing algorithm, router observability, etc.).[Misc]for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
pre-committo format your code. SeeREADME.mdfor installation.DCO and Signed-off-by
When contributing changes to this project, you must agree to the DCO. Commits must include a
Signed-off-by:header which certifies agreement with the terms of the DCO.Using
-swithgit commitwill automatically add this header.What to Expect for the Reviews