Skip to content

[Fix] Make dashboard builder context menu keyboard accessible - #3545

Open
yuki-uix wants to merge 3 commits into
vllm-project:mainfrom
yuki-uix:codex/3515-context-menu-a11y
Open

[Fix] Make dashboard builder context menu keyboard accessible#3545
yuki-uix wants to merge 3 commits into
vllm-project:mainfrom
yuki-uix:codex/3515-context-menu-a11y

Conversation

@yuki-uix

@yuki-uix yuki-uix commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • render Expression Builder context-menu actions as semantic menu-item buttons
  • focus the first action when the menu opens and support Arrow Up/Down, Home, End, and Escape
  • restore focus after Escape and add visible keyboard focus styling
  • add regression coverage for menu semantics and keyboard behavior

Closes #3515

Validation

  • npm run test:unit (736 tests passed)
  • npm run type-check
  • npm run build
  • targeted Vitest accessibility tests (10 tests passed)
  • changed-file ESLint (0 errors; 3 pre-existing warnings in ExpressionBuilderInner.tsx)

Note: make dashboard-check completed the frontend lint stage, then stopped because golangci-lint is not installed in the local environment.

@netlify

netlify Bot commented Sep 7, 2026

Copy link
Copy Markdown

Deploy Preview for vllm-semantic-router ready!

Name Link
🔨 Latest commit ad533dc
🔍 Latest deploy log https://app.netlify.com/projects/vllm-semantic-router/deploys/6a9f669c2470da0008e0b5da
😎 Deploy Preview https://deploy-preview-3545--vllm-semantic-router.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Signed-off-by: yuki.x <yuki.uix@gmail.com>
@yuki-uix
yuki-uix force-pushed the codex/3515-context-menu-a11y branch from 3c3214d to a0fdb5f Compare September 7, 2026 10:50
@github-actions github-actions Bot added pr/needs-rebase Needs rebase or conflict resolution. wg/developer-experience-ecosystem Owned by the Developer Experience and Ecosystem Workgroup. labels Sep 7, 2026
@github-actions github-actions Bot added pr/needs-review Ready for reviewer attention. and removed pr/needs-rebase Needs rebase or conflict resolution. labels Sep 7, 2026
@yuki-uix yuki-uix changed the title fix(dashboard): make builder context menu keyboard accessible [Fix] Make dashboard builder context menu keyboard accessible Sep 7, 2026
@github-actions github-actions Bot added pr/needs-rebase Needs rebase or conflict resolution. and removed pr/needs-review Ready for reviewer attention. labels Sep 7, 2026
@github-actions github-actions Bot added pr/needs-review Ready for reviewer attention. and removed pr/needs-rebase Needs rebase or conflict resolution. labels Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr/needs-review Ready for reviewer attention. wg/developer-experience-ecosystem Owned by the Developer Experience and Ecosystem Workgroup.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Dashboard collapsible headers and context menus are not keyboard reachable

2 participants