Skip to content

Commit 8f0a95c

Browse files
committed
Rename compute_topk_logprobs to compute_topk_scores
The function now returns either logits or logprobs depending on logits_mode, so "logprobs" in the name is misleading. "scores" is the neutral term already used throughout the codebase. Signed-off-by: Allen Shen <aoshen@inferact.ai>
1 parent 1766f40 commit 8f0a95c

5 files changed

Lines changed: 9 additions & 9 deletions

File tree

vllm/model_executor/models/diffusion_gemma.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
from vllm.v1.worker.gpu.buffer_utils import UvaBackedTensor, async_copy_to_gpu
5353
from vllm.v1.worker.gpu.input_batch import InputBatch
5454
from vllm.v1.worker.gpu.model_states.interface import ModelState
55-
from vllm.v1.worker.gpu.sample.logprob import compute_topk_logprobs
55+
from vllm.v1.worker.gpu.sample.logprob import compute_topk_scores
5656
from vllm.v1.worker.gpu.sample.output import SamplerOutput
5757
from vllm.v1.worker.gpu.sample.penalties import use_penalty
5858
from vllm.v1.worker.gpu.states import RequestState
@@ -1343,7 +1343,7 @@ def __call__(
13431343
# positions are never emitted.
13441344
k_i = int(valid_canvas_len_np[li])
13451345
start = li * CL
1346-
self._pending_logprobs[slot.item()] = compute_topk_logprobs(
1346+
self._pending_logprobs[slot.item()] = compute_topk_scores(
13471347
flat_logits[start : start + k_i],
13481348
max_num_logprobs,
13491349
argmax_tokens[local_idx][:k_i],

vllm/v1/worker/gpu/sample/logprob.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ def compute_token_logprobs(
106106
return logprobs
107107

108108

109-
def compute_topk_logprobs(
109+
def compute_topk_scores(
110110
logits: torch.Tensor,
111111
num_logprobs: int,
112112
sampled_token_ids: torch.Tensor,

vllm/v1/worker/gpu/sample/prompt_logprob.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
from vllm.triton_utils import tl, triton
1010
from vllm.v1.outputs import LogprobsTensors
1111
from vllm.v1.worker.gpu.input_batch import InputBatch
12-
from vllm.v1.worker.gpu.sample.logprob import compute_topk_logprobs
12+
from vllm.v1.worker.gpu.sample.logprob import compute_topk_scores
1313

1414

1515
class PromptLogprobsWorker:
@@ -229,7 +229,7 @@ def compute_prompt_logprobs_with_chunking(
229229
)
230230
chunk_tgt = prompt_token_ids[start_idx:end_idx]
231231

232-
result = compute_topk_logprobs(
232+
result = compute_topk_scores(
233233
prompt_logits,
234234
requested_num,
235235
chunk_tgt,

vllm/v1/worker/gpu/sample/sampler.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
from vllm.v1.worker.gpu.sample.logit_bias import LogitBiasState
2020
from vllm.v1.worker.gpu.sample.logprob import (
2121
LogprobTokenIdsState,
22-
compute_topk_logprobs,
22+
compute_topk_scores,
2323
)
2424
from vllm.v1.worker.gpu.sample.output import SamplerOutput
2525
from vllm.v1.worker.gpu.sample.penalties import PenaltiesState
@@ -105,7 +105,7 @@ def __call__(
105105
expanded_logits = logits.shape[0] != idx_mapping_np.shape[0]
106106
cu_num_logits = cu_num_logits_np.tolist() if expanded_logits else None
107107
num_logprobs = max_num_logprobs if max_num_logprobs != NO_LOGPROBS else 0
108-
logprobs_tensors = compute_topk_logprobs(
108+
logprobs_tensors = compute_topk_scores(
109109
logits,
110110
num_logprobs,
111111
sampled,

vllm/v1/worker/gpu/spec_decode/rejection_sampler.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
get_num_sampled_and_rejected,
1212
)
1313
from vllm.v1.worker.gpu.metrics.logits import get_num_nans
14-
from vllm.v1.worker.gpu.sample.logprob import compute_topk_logprobs
14+
from vllm.v1.worker.gpu.sample.logprob import compute_topk_scores
1515
from vllm.v1.worker.gpu.sample.output import SamplerOutput
1616
from vllm.v1.worker.gpu.sample.sampler import Sampler
1717
from vllm.v1.worker.gpu.sample.states import NO_LOGPROBS
@@ -91,7 +91,7 @@ def _get_logprobs_tensors(
9191
num_warps=1,
9292
)
9393
expanded_logits = num_logits != input_batch.idx_mapping.shape[0]
94-
return compute_topk_logprobs(
94+
return compute_topk_scores(
9595
logits,
9696
max_num_logprobs,
9797
flat_sampled,

0 commit comments

Comments
 (0)