Inspections - casts, java style array, simplify function closures (#187)

* remove redundant casts

* use JAVA style array declaration

* remove redundatnt continue as last statement
simplify return command

Author: Pitterling

src/main/java/net/atomique/ksar/Main.java

@@ -108,8 +108,8 @@ public static void main(String[] args) {
           } else {
             exit_error(resource.getString("INPUT_REQUIRE_ARG"));
           }
-          continue;
         }
+
       }
     }
 

src/main/java/net/atomique/ksar/graph/Graph.java

@@ -7,7 +7,6 @@
 
 import net.atomique.ksar.Config;
 import net.atomique.ksar.GlobalOptions;
-import net.atomique.ksar.OSParser;
 import net.atomique.ksar.kSar;
 import net.atomique.ksar.ui.SortedTreeNode;
 import net.atomique.ksar.ui.TreeNodeInfo;
@@ -202,7 +201,7 @@ private boolean add_datapoint_plot(Second now, int col, String colheader, double
       // insert not possible
       // check if column can be update
       StatConfig statconfig =
-          ((OSParser) mysar.myparser).get_OSConfig().getStat(mysar.myparser.getCurrentStat());
+          mysar.myparser.get_OSConfig().getStat(mysar.myparser.getCurrentStat());
       if (statconfig != null) {
         if (statconfig.canDuplicateTime()) {
           Number oldval = ((Stats.get(col))).getValue(now);

src/main/java/net/atomique/ksar/ui/GraphSelection.java

@@ -121,7 +121,7 @@ private void unselectallButtonActionPerformed(
   public void toggle_checkbox(JPanel panel, boolean checked) {
     Component[] list = panel.getComponents();
     for (int i = 0; i < list.length; i++) {
-      Component tmp = (Component) list[i];
+      Component tmp = list[i];
       if (tmp instanceof JPanel) {
         JPanel obj = (JPanel) tmp;
         toggle_checkbox(obj, checked);

src/main/java/net/atomique/ksar/ui/Preferences.java

@@ -31,7 +31,7 @@ public Preferences(java.awt.Frame parent) {
   }
 
   private void load_landf() {
-    UIManager.LookAndFeelInfo looks[] = UIManager.getInstalledLookAndFeels();
+    UIManager.LookAndFeelInfo[] looks = UIManager.getInstalledLookAndFeels();
     for (int i = 0, n = looks.length; i < n; i++) {
       String tmp = looks[i].getName();
       UI_lanf_model.addElement(tmp);

src/main/java/net/atomique/ksar/xml/CnxHistory.java

@@ -81,10 +81,7 @@ public boolean isValid() {
     if (hostname == null) {
       return false;
     }
-    if (commandList.isEmpty()) {
-      return false;
-    }
-    return true;
+    return !commandList.isEmpty();
   }
 
   public void dump() {