Add spell script for using bg banners.

Author: ratkosrb

sql/migrations/20250523175837_world.sql

@@ -0,0 +1,20 @@
+DROP PROCEDURE IF EXISTS add_migration;
+DELIMITER ??
+CREATE PROCEDURE `add_migration`()
+BEGIN
+DECLARE v INT DEFAULT 1;
+SET v = (SELECT COUNT(*) FROM `migrations` WHERE `id`='20250523175837');
+IF v = 0 THEN
+INSERT INTO `migrations` VALUES ('20250523175837');
+-- Add your query below.
+
+
+UPDATE `spell_template` SET `script_name`='spell_opening_battleground_banner' WHERE `entry`=21651;
+
+
+-- End of migration.
+END IF;
+END??
+DELIMITER ;
+CALL add_migration();
+DROP PROCEDURE IF EXISTS add_migration;

src/game/Spells/Spell.cpp

@@ -8707,24 +8707,9 @@ void Spell::SetClientStarted(bool bisClientStarted)
 
 void Spell::OnSpellLaunch()
 {
-    if (!m_casterUnit || !m_caster->IsInWorld())
+    if (!m_casterUnit || !m_casterUnit->IsInWorld())
         return;
 
-    // Make sure the player is sending a valid GO target and lock ID. SPELL_EFFECT_OPEN_LOCK
-    // can succeed with a lockId of 0
-    if (m_spellInfo->Id == 21651)
-    {
-        if (GameObject* go = m_targets.getGOTarget())
-        {
-            LockEntry const* lockInfo = sLockStore.LookupEntry(go->GetGOInfo()->GetLockId());
-            if (lockInfo && lockInfo->Index[1] == LOCKTYPE_SLOW_OPEN)
-            {
-                Spell* visual = new Spell(m_casterUnit, sSpellMgr.GetSpellEntry(24390), true);
-                visual->prepare();
-            }
-        }
-    }
-
     unitTarget = m_targets.getUnitTarget();
 
     // Charge handled here instead of in effect handler

src/scripts/spells/spell_special.cpp

@@ -246,6 +246,33 @@ SpellScript* GetScript_ClearAllCooldowns(SpellEntry const*)
     return new ClearAllCooldownsScript();
 }
 
+// 21651 - Opening
+struct OpeningBattlegroundBannerScript : public SpellScript
+{
+    void OnSuccessfulStart(Spell* spell) const final
+    {
+        if (!spell->m_casterUnit)
+            return;
+
+        if (GameObject* go = spell->m_targets.getGOTarget())
+        {
+            // Make sure the player is sending a valid GO target and lock ID.
+            // SPELL_EFFECT_OPEN_LOCK can succeed with a lockId of 0.
+            LockEntry const* lockInfo = sLockStore.LookupEntry(go->GetGOInfo()->GetLockId());
+            if (lockInfo && lockInfo->Index[1] == LOCKTYPE_SLOW_OPEN)
+            {
+                Spell* visual = new Spell(spell->m_casterUnit, sSpellMgr.GetSpellEntry(24390), true);
+                visual->prepare();
+            }
+        }
+    }
+};
+
+SpellScript* GetScript_OpeningBattlegroundBanner(SpellEntry const*)
+{
+    return new OpeningBattlegroundBannerScript();
+}
+
 void AddSC_special_spell_scripts()
 {
     Script* newscript;
@@ -309,4 +336,9 @@ void AddSC_special_spell_scripts()
     newscript->Name = "spell_clear_all_cooldowns";
     newscript->GetSpellScript = &GetScript_ClearAllCooldowns;
     newscript->RegisterSelf();
+
+    newscript = new Script;
+    newscript->Name = "spell_opening_battleground_banner";
+    newscript->GetSpellScript = &GetScript_OpeningBattlegroundBanner;
+    newscript->RegisterSelf();
 }