chore: Correct some comments as well as rename new tests (#463)

Signed-off-by: Wendy Arango <[email protected]>

Author: warango4

pkg/cli-runtime/config_test.go

@@ -336,62 +336,62 @@ func TestConfig_PrintPrompt(t *testing.T) {
 		printer:     config.Eboldf,
 		stderr:      printer.BoldColor.Sprint("hello"),
 	}, {
-		name:    "Printf",
+		name:    "do not print - Printf",
 		format:  "%s",
 		args:    []interface{}{"hello"},
 		printer: config.Printf,
 	}, {
-		name:    "Eprintf",
+		name:    "do not print - Eprintf",
 		format:  "%s",
 		args:    []interface{}{"hello"},
 		printer: config.Eprintf,
 	}, {
-		name:    "Infof",
+		name:    "do not print - Infof",
 		format:  "%s",
 		args:    []interface{}{"hello"},
 		printer: config.Infof,
 	}, {
-		name:    "Einfof",
+		name:    "do not print - Einfof",
 		format:  "%s",
 		args:    []interface{}{"hello"},
 		printer: config.Einfof,
 	}, {
-		name:    "Successf",
+		name:    "do not print - Successf",
 		format:  "%s",
 		args:    []interface{}{"hello"},
 		printer: config.Successf,
 	}, {
-		name:    "Esuccessf",
+		name:    "do not print - Esuccessf",
 		format:  "%s",
 		args:    []interface{}{"hello"},
 		printer: config.Esuccessf,
 	}, {
-		name:    "Faintf",
+		name:    "do not print - Faintf",
 		format:  "%s",
 		args:    []interface{}{"hello"},
 		printer: config.Faintf,
 	}, {
-		name:    "Efaintf",
+		name:    "do not print - Efaintf",
 		format:  "%s",
 		args:    []interface{}{"hello"},
 		printer: config.Efaintf,
 	}, {
-		name:    "Errorf",
+		name:    "do not print - Errorf",
 		format:  "%s",
 		args:    []interface{}{"hello"},
 		printer: config.Errorf,
 	}, {
-		name:    "Eerrorf",
+		name:    "do not print - Eerrorf",
 		format:  "%s",
 		args:    []interface{}{"hello"},
 		printer: config.Eerrorf,
 	}, {
-		name:    "Boldf",
+		name:    "do not print - Boldf",
 		format:  "%s",
 		args:    []interface{}{"hello"},
 		printer: config.Boldf,
 	}, {
-		name:    "Eboldf",
+		name:    "do not print - Eboldf",
 		format:  "%s",
 		args:    []interface{}{"hello"},
 		printer: config.Eboldf,

pkg/commands/workload.go

@@ -449,13 +449,12 @@ func (opts *WorkloadOptions) PublishLocalSource(ctx context.Context, c *cli.Conf
 	if opts.LocalPath == "" {
 		return true, nil
 	}
-	// showPrompts is the opposite to c.NoColor
-	// to determine whether there should be prompts or not
 
 	var okToPush bool
 	taggedImage := strings.Split(workload.Spec.Source.Image, "@sha")[0]
 	if shouldPrint {
-		// display survey to publish local source if user
+		// display survey to publish local source if user did not use
+		// --yes flag to accept workload create/update
 		okToPush = opts.checkToPublishLocalSource(taggedImage, c, workload)
 		if !okToPush {
 			return okToPush, nil
@@ -492,6 +491,7 @@ func (opts *WorkloadOptions) PublishLocalSource(ctx context.Context, c *cli.Conf
 	currentRegistryOpts := source.RegistryOpts{CACertPaths: opts.CACertPaths, RegistryUsername: opts.RegistryUsername, RegistryPassword: opts.RegistryPassword, RegistryToken: opts.RegistryToken}
 	var reg registry.Registry
 	var err error
+	// if there is no color or there should not be any prompts, skip the progress bar
 	if c.NoColor || !shouldPrint {
 		reg, err = source.NewRegistry(ctx, &currentRegistryOpts)
 	} else {

pkg/commands/workload_create.go

@@ -131,7 +131,7 @@ func (opts *WorkloadCreateOptions) Exec(ctx context.Context, c *cli.Config) erro
 			c.Printf("\n")
 		}
 	} else if opts.Output != "" && opts.Yes {
-		// since there are no prompts, set okToApply to true (accepted through --yes)
+		// since there are no prompts, set okToCreate to true (accepted through --yes)
 		okToCreate = true
 		if _, err := opts.PublishLocalSource(ctx, c, workload, workload, shouldPrint); err != nil {
 			return err