-
Notifications
You must be signed in to change notification settings - Fork 24
Open
Description
Elaborating on a comment from @bryanv .
ref:
nsx-operator/pkg/apis/v1alpha1/subnetport_types.go
Lines 11 to 16 in 8cdf0a2
| // SubnetPortSpec defines the desired state of SubnetPort. | |
| type SubnetPortSpec struct { | |
| // Subnet defines the parent Subnet name of the SubnetPort. | |
| Subnet string `json:"subnet,omitempty"` | |
| // SubnetSet defines the parent SubnetSet name of the SubnetPort. | |
| SubnetSet string `json:"subnetSet,omitempty"` |
Can we make comments indicating that Subnet and SubnetSet are exclusive for a SubnetPortSpec? That if you choose "Subnet", then "SubnetSet" may not also be selected - and what the expected failure case would be here. Additionally - is the failure handled by a ValidatingWebhook, or will the SubnetPort resolve incorrectly (ValidatingWebhook might be better to reject outright).
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels