Skip to content

Make note that Subnet/SubnetSet for SubnetPorts are exclusive #436

@ihgann

Description

@ihgann

Elaborating on a comment from @bryanv .

ref:

// SubnetPortSpec defines the desired state of SubnetPort.
type SubnetPortSpec struct {
// Subnet defines the parent Subnet name of the SubnetPort.
Subnet string `json:"subnet,omitempty"`
// SubnetSet defines the parent SubnetSet name of the SubnetPort.
SubnetSet string `json:"subnetSet,omitempty"`

Can we make comments indicating that Subnet and SubnetSet are exclusive for a SubnetPortSpec? That if you choose "Subnet", then "SubnetSet" may not also be selected - and what the expected failure case would be here. Additionally - is the failure handled by a ValidatingWebhook, or will the SubnetPort resolve incorrectly (ValidatingWebhook might be better to reject outright).

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions