Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Shallow copy of non-map fields within clusterbootstrapclone.go#addMissingFields() #2785

Open
@danniel1205

Description

(This is used to request new product features)

Describe the feature request

With current implementation under addons/pkg/util/clusterbootstrapclone/clusterbootstrapclone.go#addMissingFields, it does a shallow copy of the non-map fields (destination[keyInFrom] = valueInFrom) . This works fine when handling non-pointer values, but we might want to consider primitive pointer cases. (e.g., *int)

Describe alternatives you've considered

NA

Affected product area (please put an X in all that apply)

  • APIs
  • Addons
  • CLI
  • Docs
  • IAM
  • Installation
  • Plugin
  • Security
  • Test and Release
  • User Experience

Additional context

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions