[Linux] Update VHBA testing known issues (#711)

Signed-off-by: Qi Zhang <[email protected]>

Author: keirazhang

linux/network_device_ops/apply_new_network_config.yml

@@ -24,7 +24,7 @@
 
     - name: "Set fact of command for adding network connection with static IP addresss"
       ansible.builtin.set_fact:
-        nmcli_connection_add_cmd:  >-
+        nmcli_connection_add_cmd: >-
           nmcli connection add type ethernet ifname {{ new_network_adapter }}
           con-name {{ new_network_adapter }} ipv4.method manual
           ipv4.addresses {{ new_nic_ipv4 }}/{{ new_nic_net_prefix }}
@@ -33,7 +33,7 @@
 
     - name: "Set fact of command for adding network connection with DHCP IP addresss"
       ansible.builtin.set_fact:
-        nmcli_connection_add_cmd:  >-
+        nmcli_connection_add_cmd: >-
           nmcli connection add type ethernet ifname {{ new_network_adapter }}
           con-name {{ new_network_adapter }} {{ nmcli_ipv6_method }}
       when: new_nic_ipv4_method == 'dhcp'

linux/network_device_ops/hot_add_network_adapter.yml

@@ -35,10 +35,12 @@
   vars:
     vm_wait_connection_timeout: 60
 
-- name: "Get new messages in dmesg ring buffer"
+- name: "Collect dmesg after hot adding a new network adapter"
   include_tasks: ../utils/collect_dmesg.yml
   vars:
-    dmesg_output_file_name: 'dmesg_after_nic_hotadd.log'
+    dmesg_options: '-c'
+    dmesg_output_file_name: 'dmesg_after_nic_hot_add.log'
+    dmesg_check_call_trace: true
 
 - name: "Set match string for newly added NIC in dmesg ring buffer"
   ansible.builtin.set_fact:

linux/network_device_ops/hot_remove_network_adapter.yml

@@ -7,7 +7,7 @@
   include_tasks: ../../common/vm_remove_network_adapter.yml
   vars:
     netadapter_mac_addr: "{{ new_network_adapter_mac_addr }}"
-    vm_remove_adapter_ignore_errors: True
+    vm_remove_adapter_ignore_errors: true
 
 - name: "Network adapter hot-remove succeeded"
   ansible.builtin.debug:
@@ -30,7 +30,7 @@
         - known_issue
       when:
         - remove_adapter.module_stderr is defined
-        - (remove_adapter.module_stderr | 
+        - (remove_adapter.module_stderr |
            regex_findall("The guest operating system did not respond to a hot-remove request for device '.*' in a timely manner.") | length > 0)
         - adapter_type == "pvrdma"
         - esxi_version is version('7.0.0', '>=')
@@ -47,6 +47,13 @@
   vars:
     vm_wait_connection_timeout: 60
 
+- name: "Collect dmesg after hot removing the new network adapter"
+  include_tasks: ../utils/collect_dmesg.yml
+  vars:
+    dmesg_options: '-c'
+    dmesg_output_file_name: 'dmesg_after_nic_hot_remove.log'
+    dmesg_check_call_trace: true
+
 - name: "Get network adapter status after hot-remove"
   include_tasks: ../utils/get_network_adapters_status.yml
 

linux/setup/linux_test_rescue.yml

@@ -8,27 +8,20 @@
   include_tasks: ../utils/collect_dmesg.yml
   vars:
     dmesg_ignore_errors: true
-    dmesg_output_file_name: "dmesg_at_test_failure.log"
+    dmesg_output_file_name: "dmesg_at_{{ ansible_play_name }}_failure.log"
+    dmesg_check_call_trace: true
 
 - name: "No output file for dmesg"
   ansible.builtin.debug:
     msg: "There is no new messages in dmesg ring buffer or failed to get dmesg output"
   when: not dmesg_output_file_path
 
-- name: "Detect errors in dmesg output"
-  when: dmesg_output_file_path
-  block:
-    - name: "Extract errors from guest OS dmesg"
-      include_tasks: ../../common/extract_errors_from_log.yml
-      vars:
-        extract_log_file_path: "{{ dmesg_output_file_path }}"
-
-    - name: "Display detected errors from guest OS dmesg"
-      ansible.builtin.debug:
-        msg: "{{ errors_in_log }}"
-      tags:
-        - fail_message
-      when: errors_in_log | length > 0
+- name: "Display call trace stack detected in dmesg output"
+  ansible.builtin.debug:
+    msg: "{{ dmesg_call_trace_stack }}"
+  tags:
+    - fail_message
+  when: dmesg_call_trace_stack | length > 0
 
 - name: "Collect /var/log/messages at test case failure"
   include_tasks: ../utils/fetch_file.yml

linux/setup/test_setup.yml

@@ -96,3 +96,7 @@
         service_enabled: true
         service_state: "restarted"
       when: dns_servers_output.stdout.find("DNS Servers:") == -1
+
+- name: "Initialize the fact of dmesg call trace stack"
+  ansible.builtin.set_fact:
+    dmesg_call_trace_stack: []

linux/utils/collect_dmesg.yml

@@ -8,8 +8,12 @@
 #   dmesg_output_file_name (optional): the file name for saving dmesg output in test case log folder
 #   dmesg_ignore_errors (optional): ignore errors when executing dmesg. Default is false.
 #   dmesg_no_log (optional): true to hide output on console. Default is false.
+#   dmesg_check_call_trace (optional): whether to check there is call trace or not in dmesg output.
+#     Default value is false.
 # Return:
 #   dmesg_output_file_path: the file path to save dmesg output at localhost
+#   dmesg_call_trace_stack: all call traces found in current test case when
+#     dmesg_check_call_trace is true.
 #
 - name: "Initialize facts of dmesg command result and output file path at localhost"
   ansible.builtin.set_fact:
@@ -50,6 +54,26 @@
         - save_dmesg_result.failed is defined
         - not save_dmesg_result.failed
 
-    - name: "Display the demst output file path"
+    - name: "Display the dmesg output file path"
       ansible.builtin.debug:
         msg: "The output of dmesg is saved into {{ dmesg_output_file_path }}"
+
+    - name: "Check whether there is call trace in dmesg output"
+      when: dmesg_check_call_trace | default(false)
+      block:
+        - name: "Extract errors from dmesg output in guest OS"
+          include_tasks: ../../common/extract_errors_from_log.yml
+          vars:
+            extract_log_file_path: "{{ dmesg_output_file_path }}"
+
+        - name: "Update fact of call traces found in test case {{ ansible_play_name }}"
+          ansible.builtin.set_fact:
+            dmesg_call_trace_stack: >-
+              {{
+                dmesg_call_trace_stack |
+                union(["Found call trace in "~ dmesg_output_file_name]) |
+                union(errors_in_log)
+              }}
+          when:
+            - errors_in_log | length > 0
+            - errors_in_log is search('Call Trace')

linux/utils/freebsd_get_geom_list.yml

@@ -24,6 +24,7 @@
   ansible.builtin.shell: "sysctl -n kern.geom.confxml"
   delegate_to: "{{ vm_guest_ip }}"
   register: geom_in_xml_result
+  no_log: true
 
 - name: "Set fact of FreeBSD GEOM config info"
   ansible.builtin.set_fact:

linux/utils/get_device_list.yml

@@ -9,60 +9,64 @@
 #   guest_device_list: A list of all guest devices or a list of guest devices with given type
 #                      and attributes of name, type, size in bytes and filesystem type
 #
-- name: "Initialize the fact of device list and command"
+- name: "Initialize the fact of device list in guest OS"
   ansible.builtin.set_fact:
     guest_device_list: []
-    get_device_list_cmd: |-
-      {%- if guest_os_family == 'FreeBSD' -%}lsblk -d | grep -i '^[a-z]' | grep -v SIZE | grep -v cd0
-      {%- else -%}lsblk -o NAME,TYPE,SIZE,FSTYPE -b --nodeps
-      {%- endif -%}
 
-- name: "Update command to get device list with type of {{ guest_device_type }}"
-  ansible.builtin.set_fact:
-    get_device_list_cmd: "{{ get_device_list_cmd ~ ' | grep ' ~ guest_device_type }}"
-  when:
-    - guest_device_type is defined
-    - guest_device_type
-    - guest_os_family != "FreeBSD"
+- name: "Get device list on Linux"
+  when: guest_os_ansible_system == 'linux'
+  block:
+    - name: "Get device list of type {{ guest_device_type }} on {{ vm_guest_os_distribution }}"
+      ansible.builtin.shell: "lsblk -o NAME,TYPE,SIZE,FSTYPE -b --nodeps | grep -i {{ guest_device_type }}"
+      delegate_to: "{{ vm_guest_ip }}"
+      changed_when: false
+      ignore_errors: true
+      register: list_device_result
 
-- name: "Get block device list"
-  ansible.builtin.shell: "{{ get_device_list_cmd }}"
-  delegate_to: "{{ vm_guest_ip }}"
-  changed_when: false
-  ignore_errors: true
-  register: lsblk_result
+    - name: "Set fact of {{ guest_device_type }} device list on {{ vm_guest_os_distribution }}"
+      ansible.builtin.set_fact:
+        guest_device_list: >
+          {{
+             guest_device_list | union([
+                 dict(['name', 'type', 'size', 'fstype'] |
+                      zip_longest(item.split(), fillvalue=''))
+             ])
+          }}
+      with_items: "{{ list_device_result.stdout_lines }}"
+      when:
+        - list_device_result is defined
+        - list_device_result.stdout_lines is defined
+        - list_device_result.stdout_lines | length > 0
 
-- name: "Set the fact of block device list for {{ guest_os_ansible_distribution }}"
-  ansible.builtin.set_fact:
-    guest_device_list: >
-      {{
-         guest_device_list | union([
-             dict(['name', 'type', 'size', 'fstype'] |
-                  zip_longest(item.split(), fillvalue=''))
-         ])
-      }}
-  with_items: "{{ lsblk_result.stdout_lines }}"
-  when:
-    - guest_os_family != 'FreeBSD'
-    - lsblk_result is defined
-    - lsblk_result.stdout_lines is defined
-    - lsblk_result.stdout_lines | length > 0
+- name: "Get device list on FreeBSD"
+  when: guest_os_ansible_system == 'freebsd'
+  block:
+    - name: "Get device list of type {{ guest_device_type }} on {{ vm_guest_os_distribution }}"
+      include_tasks: freebsd_get_geom_list.yml
+      vars:
+        freebsd_geom_class: "DISK"
 
-- name: "Set the fact of block device list for FreeBSD"
-  ansible.builtin.set_fact:
-    guest_device_list: >
-      {{
-         guest_device_list | union([
-             dict(['name', 'size', 'model'] |
-                  zip_longest(item.split(None, maxsplit=2), fillvalue=''))
-         ])
-      }}
-  with_items: "{{ lsblk_result.stdout_lines }}"
-  when:
-    - guest_os_family == 'FreeBSD'
-    - lsblk_result is defined
-    - lsblk_result.stdout_lines is defined
-    - lsblk_result.stdout_lines | length > 0
+    - name: "Update fact of GEOM class list with {{ guest_device_type }} only"
+      ansible.builtin.set_fact:
+        freebsd_device_list: "{{ freebsd_geom_list | selectattr('name', 'match', 'cd\\d+') }}"
+      when: guest_device_type | lower == 'rom'
+
+    - name: "Update fact of GEOM class list with {{ guest_device_type }} only"
+      ansible.builtin.set_fact:
+        freebsd_device_list: "{{ freebsd_geom_list | rejectattr('name', 'match', 'cd\\d+') }}"
+      when: guest_device_type | lower != 'rom'
+
+    - name: "Set fact of {{ guest_device_type }} device list on {{ vm_guest_os_distribution }}"
+      ansible.builtin.set_fact:
+        guest_device_list: >
+          {{
+             guest_device_list |
+             union([{'name': item.name,
+                     'size': item.provider.mediasize | default(0),
+                     'model': item.provider.config.descr | default('') }])
+          }}
+      with_items: "{{ freebsd_device_list }}"
+      when: freebsd_device_list | length > 0
 
 - name: "Print device list in guest OS"
   ansible.builtin.debug: var=guest_device_list

linux/vhba_hot_add_remove/get_boot_disk_ctrl_type.yml

@@ -0,0 +1,68 @@
+# Copyright 2025 VMware, Inc.
+# SPDX-License-Identifier: BSD-2-Clause
+---
+# Get the boot disk controler type on Linux
+# Return:
+#   guest_boot_disk_ctrl_type: The boot disk controller type
+#
+- name: "Initialze the fact of boot disk controller type in guest OS"
+  ansible.builtin.set_fact:
+    guest_boot_disk_ctrl_type: "{{ new_vm | ternary(boot_disk_controller, '') }}"
+
+- name: "Get boot disk controller type on existing VM"
+  when:
+    - not new_vm
+    - guest_os_ansible_system == 'linux'
+  block:
+    - name: "Get ansible facts of system devices in guest OS"
+      include_tasks: ../../common/get_system_info.yml
+      vars:
+        filter:
+          - 'ansible_mounts'
+          - 'ansible_devices'
+
+    - name: "Get boot disk partitions in guest OS"
+      ansible.builtin.set_fact:
+        guest_boot_disk_partitions: >-
+          {{
+            guest_system_info.ansible_mounts |
+            selectattr('device', 'match', '/dev/(sd|nvme)') |
+            selectattr('mount', 'match', '/boot|^/$') |
+            map(attribute='device') |
+            map('replace', '/dev/', '')
+          }}
+
+    - name: "Failed to find disk partitions for boot or root file system"
+      ansible.builtin.fail:
+        msg: "All disk partitions are {{ guest_system_info.ansible_mounts | selectattr('device', 'match', '/dev/(sd|nvme)') }}"
+      when: guest_boot_disk_partitions | length == 0
+
+    - name: "Get boot disk controller in guest OS"
+      ansible.builtin.set_fact:
+        guest_boot_disk_controller: >-
+          {{
+            guest_system_info.ansible_devices.values() |
+            selectattr('partitions', 'contains', guest_boot_disk_partitions[0]) |
+            map(attribute='host') | first
+          }}
+
+    - name: "Set fact of boot disk controller type in guest OS"
+      ansible.builtin.set_fact:
+        guest_boot_disk_ctrl_type: |-
+          {%- if guest_boot_disk_controller is search('PVSCSI') -%}paravirtual
+          {%- elif guest_boot_disk_controller is search('(Non-Volatile memory controller)|NVMe') -%}nvme
+          {%- elif guest_boot_disk_controller is search('SATA') -%}sata
+          {%- elif guest_boot_disk_controller is search('LSI.*SAS') -%}lsilogicsas
+          {%- elif guest_boot_disk_controller is search('LSI.*SCSI') -%}lsilogic
+          {%- elif guest_boot_disk_controller is search('IDE') -%}ide
+          {%- endif -%}
+
+    - name: "Check boot disk controller type in guest OS"
+      ansible.builtin.assert:
+        that:
+          - guest_boot_disk_ctrl_type
+        fail_msg: "Failed to get boot disk controller type. The boot disk controller is {{ guest_boot_disk_controller }}"
+        success_msg: "The boot disk controller type is {{ guest_boot_disk_ctrl_type }}"
+
+- name: "Display the boot disk controller type in guest OS"
+  ansible.builtin.debug: var=guest_boot_disk_ctrl_type

linux/vhba_hot_add_remove/get_new_disk_info.yml

@@ -0,0 +1,32 @@
+# Copyright 2025 VMware, Inc.
+# SPDX-License-Identifier: BSD-2-Clause
+---
+# Get the new disk information in guest OS
+# Parameter:
+#   current_guest_disk_list: A list of disks in guest OS
+#
+- name: "Initialize the fact of new disk info"
+  ansible.builtin.set_fact:
+    new_guest_disk_list: []
+    new_guest_disk_info: ""
+
+- name: "Set fact of new disk list in {{ vm_guest_os_distribution }} guest OS"
+  ansible.builtin.set_fact:
+    new_guest_disk_list: "{{ current_guest_disk_list | selectattr('size', 'equalto', new_disk_size_bytes | string) }}"
+
+- name: "Set fact of the new disk info on {{ new_disk_ctrl_state }} {{ new_disk_ctrl_type }} controller"
+  ansible.builtin.set_fact:
+    new_guest_disk_info: "{{ new_guest_disk_list[0] }}"
+  when: new_guest_disk_list | length == 1
+
+- name: "Print the new disk info"
+  ansible.builtin.debug: var=new_guest_disk_info
+
+- name: "Failed to get the new disk on {{ new_disk_ctrl_state }} {{ new_disk_ctrl_type }} controller"
+  ansible.builtin.assert:
+    that:
+      - new_guest_disk_info
+      - new_guest_disk_info.name is defined
+      - new_guest_disk_info.name
+    fail_msg: "Not found the new disk from disk list {{ current_guest_disk_list }}"
+    success_msg: "The new disk is {{ new_guest_disk_info }}"