Merge pull request #634 from vmware/fix/615-decision-item-missing-closing-bracket

[vrotsc] (#615) Fix incorrectly transpiled `DecisionItem` Workflow decorator

Author: VenelinBakalov

docs/versions/latest/Release.md

@@ -28,6 +28,17 @@
 
 ## Improvements
 
+[//]: # (### *Improvement Name* )
+[//]: # (Talk ONLY regarding the improvement)
+[//]: # (Optional But higlhy recommended)
+[//]: # (#### Previous Behavior)
+[//]: # (Explain how it used to behave, regarding to the change)
+[//]: # (Optional But higlhy recommended)
+[//]: # (#### New Behavior)
+[//]: # (Explain how it behaves now, regarding to the change)
+[//]: # (Optional But higlhy recommended Specify *NONE* if missing)
+[//]: # (#### Relevant Documentation:)
+
 ### *Improve type definitions of Server class functions*
 
 Improve type definitions of Server class functions by adding `| null` to the return type.
@@ -46,16 +57,17 @@ The following function definitions have `| null` added to their return type:
 - `Server.getPackageWithName`
 - `Server.getPolicyTemplateCategoryWithPath`
 
-[//]: # (### *Improvement Name* )
-[//]: # (Talk ONLY regarding the improvement)
-[//]: # (Optional But higlhy recommended)
-[//]: # (#### Previous Behavior)
-[//]: # (Explain how it used to behave, regarding to the change)
-[//]: # (Optional But higlhy recommended)
-[//]: # (#### New Behavior)
-[//]: # (Explain how it behaves now, regarding to the change)
-[//]: # (Optional But higlhy recommended Specify *NONE* if missing)
-[//]: # (#### Relevant Documentation:)
+### *Fix Decision element transpilation issue*
+
+In Typescript workflow classes, methods with the DecisionItem decorator were transpiled incorrectly into Javascript.
+
+#### Previous Behavior
+
+Closing brackets ('{'), e.g in if blocks, were missing from the contents of the transpiled Decision element.
+
+#### New Behavior
+
+Closing brackets are no longer missing from the contents of the transpiled Decision element.
 
 ## Upgrade procedure
 

typescript/vrotsc/src/compiler/transformer/fileTransformers/workflow/decorators/decisionItemDecoratorStrategy.ts

@@ -150,7 +150,7 @@ export default class DecisionItemDecoratorStrategy extends BaseItemDecoratorStra
 	 * @param sourceText The source text to clear the `wrapper` function from
 	 * @returns The source text without the `wrapper` function
 	 */
-	private clearWrapperFunction(sourceText: string): string {
-		return sourceText.replace(/function wrapper\(\) \{|}$/gm, '').trim();
+    private clearWrapperFunction(sourceText: string): string {
+        return sourceText.replace(/function wrapper\(\) \{([\s\S]*)\}$/gm, '$1').trim();
 	}
 }