Skip to content

Network name containing "/" breaks deployment #1401

Open
@benedikt-haug

Description

@benedikt-haug

Describe the bug

Dear developer,

not all network names are supported. The sed scripts in cse break if your network name contains a "/" for example.

Would recommend to switch your sed scripts to a delimiter that isn't allowed in names.
For example sed -i 's#NETWORK#10.240.100.0/24#' $vcloud_configmap_path would work if # isn't an allowed character in names of resources.

Warm regards
Benedikt Haug

Reproduction steps

  1. Name your network "10.240.100.0/24". Its a valid name and likely used in many deployments out there.
  2. Try to spawn a cluster with that network
  3. It breaks with the error Error:Mon 31 Oct 2022 10:29:30 AM UTC 219 /root/control_plane.sh: sed -i 's/NETWORK/"10.240.100.0/24"/' $vcloud_configmap_path
  4. This is due to improper escaping of the / before the 24. Escaping the / with \ would work.

Expected behavior

All characters that are allowed in the UI should work in the scripts.

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions