vmfktools Copy API too strict.

[aklakina]

Is your feature request related to a problem? Please describe.
I Want to copy a thin provisioned disk on a datastore to a new disk. The new disk is always thick provisioned. I want the new disk to be thin provisioned too.
Right now converting a disk to thin from thick is only available with VMotion if we do not have ssh access to the esxi hosts. This makes development process horrible

Describe the solution you'd like
I want to be able to tell the govc or govmomi cli what type of disk it should create.

Describe alternatives you've considered
Currently the datastore.disk.create has no option to create a disk from another disk or file. Add the feature to datastore.disk.create so it can also copy disks.

Additional context
This line should be modified:

govmomi/object/datastore_file_manager.go

Line 127 in d62c8e9

return m.VirtualDiskManager.CopyVirtualDisk(ctx, src, srcDC, dst, dstDC, nil, force)

So instead of static nill parameter for type for the vmdk creation, propagate the parameter with a default value (to keep other calls intact) and:

govmomi/cli/datastore/cp.go

Line 72 in d62c8e9

f.BoolVar(&cmd.kind, "t", true, "Use file type to choose disk or file manager")

here also open up the parameter for the datastore.cp cli and set the default parameter inside the arguments.

This feature was already present under a different cli command (datastore.disk.cp) #999 although this seems like it was deleted.

[github-actions]

Howdy 🖐   aklakina ! Thank you for your interest in this project. We value your feedback and will respond soon.

If you want to contribute to this project, please make yourself familiar with the CONTRIBUTION guidelines.

[dougm]

Thanks @aklakina , your proposal sounds good. Can you review and try the linked PR?