panics in case of issues during vmdk upload

[vdaskalov]

Issue is observed during vCenter RDU upgrade. During target VM vmdk upload it seems there's a host connection issue an the following panic is thrown:

/12/08 00:34:46 NFC lease progress: ServerFaultCode: An error occurred while communicating with the remote host.
panic: send on closed channel
panic: close of closed channel

goroutine 1185 [running]:
github.com/vmware/govmomi/vim25/progress.tee(0xc00043e0e0, 0xc00043f030, 0xc00043e070)
external/com_github_vmware_govmomi/vim25/progress/tee.go:38 +0xb3
created by github.com/vmware/govmomi/vim25/progress.NewReader.Tee.func2 in goroutine 1096
external/com_github_vmware_govmomi/vim25/progress/tee.go:26 +0xbf

Second panic is due to vlcm retrying the operation and channel is already closed (I think).

This looks similar to: #3831, however panic is observed on another place.

Expected behavior
Expecting appropriate error to be thrown instead of panic

Affected version
v0.48.1

[github-actions]

Howdy 🖐   vdaskalov ! Thank you for your interest in this project. We value your feedback and will respond soon.

If you want to contribute to this project, please make yourself familiar with the CONTRIBUTION guidelines.