From 91305bffd702d0bc316e614c23e951a3f3e533b0 Mon Sep 17 00:00:00 2001 From: Ryan Johnson Date: Thu, 17 Apr 2025 01:10:36 -0400 Subject: [PATCH] fix: assigned but unused variables Remove assigned but unused variables. Signed-off-by: Ryan Johnson --- ...re.CloudFoundation.PasswordManagement.psd1 | 2 +- ...re.CloudFoundation.PasswordManagement.psm1 | 51 +++++++++---------- 2 files changed, 24 insertions(+), 29 deletions(-) diff --git a/VMware.CloudFoundation.PasswordManagement.psd1 b/VMware.CloudFoundation.PasswordManagement.psd1 index 572b451..7948e7d 100644 --- a/VMware.CloudFoundation.PasswordManagement.psd1 +++ b/VMware.CloudFoundation.PasswordManagement.psd1 @@ -11,7 +11,7 @@ RootModule = '.\VMware.CloudFoundation.PasswordManagement.psm1' # Version number of this module. - ModuleVersion = '1.9.0.1002' + ModuleVersion = '1.9.0.1004' # ID used to uniquely identify this module GUID = '34e5a0c7-6e6e-4f72-8b3c-1c28248f8ac9' diff --git a/VMware.CloudFoundation.PasswordManagement.psm1 b/VMware.CloudFoundation.PasswordManagement.psm1 index e841545..161dc31 100644 --- a/VMware.CloudFoundation.PasswordManagement.psm1 +++ b/VMware.CloudFoundation.PasswordManagement.psm1 @@ -4195,7 +4195,6 @@ Function Request-VcenterPasswordComplexity { $pass = Get-Password -username $user -password $pass Try { - $mgmtConnected = $false if (Test-VCFConnection -server $server) { if (Test-VCFAuthentication -server $server -user $user -pass $pass) { if (Get-VCFWorkloadDomain | Where-Object { $_.name -eq $domain }) { @@ -4205,8 +4204,8 @@ Function Request-VcenterPasswordComplexity { if (Get-VCFWorkloadDomain | Where-Object { $_.type -eq "MANAGEMENT" }) { if (($vcfMgmtVcenterDetails = Get-vCenterServerDetail -server $server -user $user -pass $pass -domainType "Management")) { if (Test-vSphereConnection -server $($vcfMgmtVcenterDetails.fqdn)) { - if (Test-vSphereAuthentication -server $vcfMgmtVcenterDetails.fqdn -user $vcfMgmtVcenterDetails.ssoAdmin -pass $vcfMgmtVcenterDetails.ssoAdminPass) { - $mgmtConnected = $true + if (-not (Test-vSphereAuthentication -server $vcfMgmtVcenterDetails.fqdn -user $vcfMgmtVcenterDetails.ssoAdmin -pass $vcfMgmtVcenterDetails.ssoAdminPass)) { + return } } } @@ -4372,8 +4371,8 @@ Function Request-VcenterAccountLockout { if ($vcenterDomain.type -ne "MANAGEMENT") { if (($vcfMgmtVcenterDetails = Get-vCenterServerDetail -server $server -user $user -pass $pass -domainType "MANAGEMENT")) { if (Test-vSphereConnection -server $($vcfMgmtVcenterDetails.fqdn)) { - if (Test-vSphereAuthentication -server $vcfMgmtVcenterDetails.fqdn -user $vcfMgmtVcenterDetails.ssoAdmin -pass $vcfMgmtVcenterDetails.ssoAdminPass) { - $mgmtConnected = $true + if (-not (Test-vSphereAuthentication -server $vcfMgmtVcenterDetails.fqdn -user $vcfMgmtVcenterDetails.ssoAdmin -pass $vcfMgmtVcenterDetails.ssoAdminPass)) { + return } } } @@ -4556,7 +4555,6 @@ Function Update-VcenterPasswordComplexity { $pass = Get-Password -username $user -password $pass Try { - $mgmtConnected = $false if (Test-VCFConnection -server $server) { if (Test-VCFAuthentication -server $server -user $user -pass $pass) { if (Get-VCFWorkloadDomain | Where-Object { $_.name -eq $domain }) { @@ -4566,8 +4564,8 @@ Function Update-VcenterPasswordComplexity { if (Get-VCFWorkloadDomain | Where-Object { $_.type -eq "MANAGEMENT" }) { if (($vcfMgmtVcenterDetails = Get-vCenterServerDetail -server $server -user $user -pass $pass -domainType "Management")) { if (Test-vSphereConnection -server $($vcfMgmtVcenterDetails.fqdn)) { - if (Test-vSphereAuthentication -server $vcfMgmtVcenterDetails.fqdn -user $vcfMgmtVcenterDetails.ssoAdmin -pass $vcfMgmtVcenterDetails.ssoAdminPass) { - $mgmtConnected = $true + if (-not (Test-vSphereAuthentication -server $vcfMgmtVcenterDetails.fqdn -user $vcfMgmtVcenterDetails.ssoAdmin -pass $vcfMgmtVcenterDetails.ssoAdminPass)) { + return } } } @@ -4658,7 +4656,6 @@ Function Update-VcenterAccountLockout { $pass = Get-Password -username $user -password $pass Try { - $mgmtConnected = $false if (Test-VCFConnection -server $server) { if (Test-VCFAuthentication -server $server -user $user -pass $pass) { if ($vcenterDomain = Get-VCFWorkloadDomain | Where-Object { $_.name -eq $domain }) { @@ -4666,8 +4663,8 @@ Function Update-VcenterAccountLockout { if ($vcenterDomain.type -ne "MANAGEMENT") { if (($vcfMgmtVcenterDetails = Get-vCenterServerDetail -server $server -user $user -pass $pass -domainType "Management")) { if (Test-vSphereConnection -server $($vcfMgmtVcenterDetails.fqdn)) { - if (Test-vSphereAuthentication -server $vcfMgmtVcenterDetails.fqdn -user $vcfMgmtVcenterDetails.ssoAdmin -pass $vcfMgmtVcenterDetails.ssoAdminPass) { - $mgmtConnected = $true + if (-not (Test-vSphereAuthentication -server $vcfMgmtVcenterDetails.fqdn -user $vcfMgmtVcenterDetails.ssoAdmin -pass $vcfMgmtVcenterDetails.ssoAdminPass)) { + return } } } @@ -5532,8 +5529,8 @@ Function Request-NsxtManagerPasswordComplexity { if (Get-VCFWorkloadDomain | Where-Object { $_.type -eq "MANAGEMENT" }) { if (($vcfMgmtVcenterDetails = Get-vCenterServerDetail -server $server -user $user -pass $pass -domainType "Management")) { if (Test-vSphereConnection -server $($vcfMgmtVcenterDetails.fqdn)) { - if (Test-vSphereAuthentication -server $vcfMgmtVcenterDetails.fqdn -user $vcfMgmtVcenterDetails.ssoAdmin -pass $vcfMgmtVcenterDetails.ssoAdminPass) { - $mgmtConnected = $true + if (-not (Test-vSphereAuthentication -server $vcfMgmtVcenterDetails.fqdn -user $vcfMgmtVcenterDetails.ssoAdmin -pass $vcfMgmtVcenterDetails.ssoAdminPass)) { + return } } } @@ -6221,20 +6218,17 @@ Function Publish-NsxManagerPasswordExpiration { if (Test-VCFAuthentication -server $server -user $user -pass $pass) { $nsxManagerPasswordExpirationObject = New-Object System.Collections.ArrayList if ($PsBoundParameters.ContainsKey('workloadDomain')) { - if (($vcfNsxDetails = Get-NsxtServerDetail -fqdn $server -username $user -password $pass -domain $workloadDomain -listNodes)) { - # foreach ($nsxtManagerNode in $vcfNsxDetails.nodes) { - $command = "Request-NsxtManagerPasswordExpiration -server $server -user $user -pass $pass -domain $workloadDomain" + $commandSwitch - $nsxPasswordExpiration = Invoke-Expression $command ; $nsxManagerPasswordExpirationObject += $nsxPasswordExpiration - # } + if (Get-NsxtServerDetail -fqdn $server -username $user -password $pass -domain $workloadDomain -listNodes) { + $command = "Request-NsxtManagerPasswordExpiration -server $server -user $user -pass $pass -domain $workloadDomain$commandSwitch" + $nsxPasswordExpiration = Invoke-Expression $command + $nsxManagerPasswordExpirationObject += $nsxPasswordExpiration } } elseif ($PsBoundParameters.ContainsKey('allDomains')) { $allWorkloadDomains = Get-VCFWorkloadDomain foreach ($domain in $allWorkloadDomains ) { - if (($vcfNsxDetails = Get-NsxtServerDetail -fqdn $server -username $user -password $pass -domain $domain.name -listNodes)) { - # foreach ($nsxtManagerNode in $vcfNsxDetails.nodes) { + if (Get-NsxtServerDetail -fqdn $server -username $user -password $pass -domain $domain.name -listNodes) { $command = "Request-NsxtManagerPasswordExpiration -server $server -user $user -pass $pass -domain $($domain.name)" + $commandSwitch $nsxPasswordExpiration = Invoke-Expression $command ; $nsxManagerPasswordExpirationObject += $nsxPasswordExpiration - # } } } } @@ -9508,8 +9502,8 @@ Function Get-AriaLocalUserPasswordExpiration { if (Get-VCFWorkloadDomain | Where-Object { $_.type -eq "MANAGEMENT" }) { if (($vcfMgmtVcenterDetails = Get-vCenterServerDetail -server $server -user $user -pass $pass -domainType "Management")) { if (Test-vSphereConnection -server $($vcfMgmtVcenterDetails.fqdn)) { - if (Test-vSphereAuthentication -server $vcfMgmtVcenterDetails.fqdn -user $vcfMgmtVcenterDetails.ssoAdmin -pass $vcfMgmtVcenterDetails.ssoAdminPass) { - $mgmtConnected = $true + if (-not (Test-vSphereAuthentication -server $vcfMgmtVcenterDetails.fqdn -user $vcfMgmtVcenterDetails.ssoAdmin -pass $vcfMgmtVcenterDetails.ssoAdminPass)) { + return } } } @@ -15561,10 +15555,11 @@ Function Request-LocalUserPasswordExpiration { if (Test-VCFConnection -server $server) { if (Test-VCFAuthentication -server $server -user $user -pass $pass) { if ($drift) { - $version = Get-VCFManager -version if ($PsBoundParameters.ContainsKey('policyFile')) { + $version = Get-VCFManager -version $command = '(Get-PasswordPolicyConfig -version $version -reportPath $reportPath -policyFile $policyFile ).' + $product + '.passwordExpiration' } else { + $version = Get-VCFManager -version $command = '(Get-PasswordPolicyConfig -version $version).' + $product + '.passwordExpiration' } $requiredConfig = Invoke-Expression $command @@ -15579,8 +15574,8 @@ Function Request-LocalUserPasswordExpiration { if (Get-VCFWorkloadDomain | Where-Object { $_.type -eq "MANAGEMENT" }) { if (($vcfMgmtVcenterDetails = Get-vCenterServerDetail -server $server -user $user -pass $pass -domainType "Management")) { if (Test-vSphereConnection -server $($vcfMgmtVcenterDetails.fqdn)) { - if (Test-vSphereAuthentication -server $vcfMgmtVcenterDetails.fqdn -user $vcfMgmtVcenterDetails.ssoAdmin -pass $vcfMgmtVcenterDetails.ssoAdminPass) { - $mgmtConnected = $true + if (-not (Test-vSphereAuthentication -server $vcfMgmtVcenterDetails.fqdn -user $vcfMgmtVcenterDetails.ssoAdmin -pass $vcfMgmtVcenterDetails.ssoAdminPass)) { + return } } } @@ -15707,8 +15702,8 @@ Function Update-LocalUserPasswordExpiration { if (Get-VCFWorkloadDomain | Where-Object { $_.type -eq "MANAGEMENT" }) { if (($vcfMgmtVcenterDetails = Get-vCenterServerDetail -server $server -user $user -pass $pass -domainType "Management")) { if (Test-vSphereConnection -server $($vcfMgmtVcenterDetails.fqdn)) { - if (Test-vSphereAuthentication -server $vcfMgmtVcenterDetails.fqdn -user $vcfMgmtVcenterDetails.ssoAdmin -pass $vcfMgmtVcenterDetails.ssoAdminPass) { - $mgmtConnected = $true + if (-not (Test-vSphereAuthentication -server $vcfMgmtVcenterDetails.fqdn -user $vcfMgmtVcenterDetails.ssoAdmin -pass $vcfMgmtVcenterDetails.ssoAdminPass)) { + return } } }