AV-152703 Fixed lint issues (#449)

* AV-152703 Fixed lint issues

Signed-off-by: Yograj Shisode <[email protected]>

Author: yograjshisode

.github/workflows/golangci-lint.yml

@@ -12,6 +12,5 @@ jobs:
         with:
           version: v1.48.0
           args: --issues-exit-code=1
-          only-new-issues: true
           skip-pkg-cache: true
           skip-build-cache: true

.github/workflows/release.yml

@@ -15,7 +15,7 @@ jobs:
           fetch-depth: 0
       -
         name: Set up Go
-        uses: actions/setup-go@v2
+        uses: actions/setup-go@v3
         with:
           go-version: 1.16
       -

avi/provider_test.go

@@ -12,7 +12,6 @@
 package avi
 
 import (
-	"fmt"
 	"os"
 	"strconv"
 	"testing"
@@ -138,6 +137,6 @@ func testAccPreCheck(t *testing.T) {
 		session.SetInsecure, session.SetTimeout(config.Timeout))
 
 	if err != nil {
-		t.Fatal(fmt.Sprintf("%+v", err))
+		t.Fatalf("%+v", err)
 	}
 }

avi/resource_avi_cloud.go

@@ -273,8 +273,8 @@ func isCloudReady(cloudState string) bool {
 	return false
 }
 
-//wait until vcenter inventory gets completed to configure mgmt IP
 func waitForVcenterState(cloudUUID string, client *clients.AviClient, maxRetry int) error {
+	// wait until vcenter inventory gets completed to configure mgmt IP
 	var robj interface{}
 	var err error
 	var inventoryState string
@@ -332,8 +332,8 @@ func waitForCloudReady(cloudUUID string, client *clients.AviClient, maxRetry int
 	return err
 }
 
-//Setup management network for vcenter cloud
 func setupVcenterMgmtNetwork(d *schema.ResourceData, meta interface{}) error {
+	// Setup management network for vcenter cloud
 	s := ResourceCloudSchema()
 	var maxRetry int
 	if retryCount, isRetry := os.LookupEnv("cloud_state_max_retry"); !isRetry {

avi/utils.go

@@ -537,8 +537,8 @@ func APIDeleteSystemDefaultCheck(d *schema.ResourceData) bool {
 	return false
 }
 
-//Open given file as a file pointer
 func mustOpen(f string) *os.File {
+	// Open given file as a file pointer
 	r, err := os.Open(f)
 	if err != nil {
 		log.Printf("[ERROR] mustOpen Error while opening file %v", f)
@@ -566,8 +566,8 @@ func createFilePointer(path string) (*os.File, error) {
 	}
 }
 
-//Function to make REST API call for upload and download.
 func MultipartUploadOrDownload(d *schema.ResourceData, meta interface{}, s map[string]*schema.Schema) error {
+	// Function to make REST API call for upload and download.
 	client := meta.(*clients.AviClient)
 	uri := d.Get("uri").(string)
 	localFile := d.Get("local_file").(string)