chore: upgrade to golangci-lint v2 (#99)

- Upgrades to golangci-lint configuration to support v2.
- Updates workflow to v7 that supports v2.

Signed-off-by: Ryan Johnson <[email protected]>

Author: tenthirtyam

.github/workflows/golangci-lint.yml

@@ -1,12 +1,13 @@
+---
 name: golangci-lint
 
 on:
   pull_request:
     paths-ignore:
-      - 'README.md'
+      - README.md
   push:
     paths-ignore:
-      - 'README.md'
+      - README.md
 
 permissions:
   contents: read
@@ -22,11 +23,11 @@ jobs:
       - name: Setup Go
         uses: actions/setup-go@0aaccfd150d50ccaeb58ebd88d36e91967a5f35b # v5.4.0
         with:
-          go-version-file: 'go.mod'
+          go-version-file: go.mod
           cache: true
       - run: go mod download
       - run: go build -v .
       - name: Run Linters
-        uses: golangci/golangci-lint-action@55c2c1448f86e01eaae002a5a3a9624417608d84 # v6.5.2
+        uses: golangci/golangci-lint-action@1481404843c368bc19ca9406f87d6e0fc97bdcfd # v7.0.0
         with:
           version: latest

.golangci.yml

@@ -1,32 +1,15 @@
-# © Broadcom. All Rights Reserved.
-# The term “Broadcom” refers to Broadcom Inc. and/or its subsidiaries.
-# SPDX-License-Identifier: MPL-2.0
+---
+version: "2"
 
-# For more information about the golangci-lint configuration file, refer to:
-# https://golangci-lint.run/usage/configuration/
-
-issues:
-  max-per-linter: 0
-  max-same-issues: 0
-  exclude-rules:
-    # Exclude errcheck for some rules.
-  - linters: [errcheck]
-    text: "Error return value of `d.Set` is not checked"
-    # Exclude revive for some rules.
-  - linters:
-    - revive
-    text: 'redefines-builtin-id: redefinition of the built-in'
-
-run:
-  deadline: 5m
+output:
+  formats:
+    text:
+      path: stdout
 
 linters:
-  disable-all: true
+  default: none
   enable:
     - errcheck
-    - gofmt
-    - goimports
-    - gosimple
     - gosec
     - govet
     - ineffassign
@@ -35,14 +18,54 @@ linters:
     - staticcheck
     - unconvert
     - unused
+  settings:
+    errcheck:
+      exclude-functions:
+        - github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema:ForceNew|Set
+        - fmt:.*
+        - io:Close
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    rules:
+      # TODO: Setting temporary exclusions.
+      - linters:
+          - errcheck
+        text: Error return value of `d.Set` is not checked
+      - linters:
+          - revive
+        text: redefines-builtin-id
+      - linters:
+          - revive
+        text: unused-parameter
+      - linters:
+          - revive
+        text: indent-error-flow
+      - linters:
+          - gosec
+        text: G402
+      - linters:
+          - goimports
+        text: formatted
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
 
-output:
-  formats:
-    - format: colored-line-number
+issues:
+  max-same-issues: 0
 
-linters-settings:
-  errcheck:
-    exclude-functions:
-      - "github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema:ForceNew|Set"
-      - "fmt:.*"
-      - "io:Close"
+formatters:
+  enable:
+    - gofmt
+    - goimports
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

README.md

@@ -26,7 +26,7 @@ Learn more:
 
     For general information about Terraform, visit [HashiCorp Developer][terraform-install] and [the project][terraform-github] on GitHub.
 
-* [Go 1.22.7][golang-install]
+* [Go 1.23.8][golang-install]
 
     Required, if [building][provider-build] the provider.
 

go.mod

@@ -1,7 +1,6 @@
 module github.com/vmware/terraform-provider-hcx
 
-go 1.22.7
-toolchain go1.24.1
+go 1.23.8
 
 require (
 	github.com/hashicorp/go-cty v1.5.0