Merge pull request #356 from vmware/bangerar/fix-backup-schedule-tests

Fix the backup schedule datasource schema and the broken converter mapping

Author: ramya-bangera

internal/resources/cluster/backupschedule/converter_mapping.go

@@ -125,15 +125,12 @@ var tfModelDataSourceRequestMap = &tfModelConverterHelper.BlockToStruct{
 	SortByKey:            "sortBy",
 	QueryKey:             "query",
 	IncludeTotalCountKey: "includeTotal",
-	NameKey:              tfModelConverterHelper.BuildDefaultModelPath("fullName", "name"),
+	NameKey:              tfModelConverterHelper.BuildDefaultModelPath("searchScope", "name"),
 	ScopeKey: &tfModelConverterHelper.BlockToStruct{
-		ClusterGroupScopeKey: &tfModelConverterHelper.BlockToStruct{
-			ClusterGroupNameKey: tfModelConverterHelper.BuildDefaultModelPath("fullName", "clusterGroupName"),
-		},
 		ClusterScopeKey: &tfModelConverterHelper.BlockToStruct{
-			ClusterNameKey:           tfModelConverterHelper.BuildDefaultModelPath("fullName", "clusterName"),
-			ManagementClusterNameKey: tfModelConverterHelper.BuildDefaultModelPath("fullName", "managementClusterName"),
-			ProvisionerNameKey:       tfModelConverterHelper.BuildDefaultModelPath("fullName", "provisionerName"),
+			ClusterNameKey:           tfModelConverterHelper.BuildDefaultModelPath("searchScope", "clusterName"),
+			ManagementClusterNameKey: tfModelConverterHelper.BuildDefaultModelPath("searchScope", "managementClusterName"),
+			ProvisionerNameKey:       tfModelConverterHelper.BuildDefaultModelPath("searchScope", "provisionerName"),
 		},
 	},
 }

internal/resources/cluster/backupschedule/datasource_schema.go

@@ -26,22 +26,19 @@ var (
 	nameDSSchema = &schema.Schema{
 		Type:        schema.TypeString,
 		Description: "The name of the backup schedule",
-		Required:    true,
-		ForceNew:    true,
+		Optional:    true,
 	}
 
 	managementClusterNameDSSchema = &schema.Schema{
 		Type:        schema.TypeString,
 		Description: "Management cluster name",
-		Required:    true,
-		ForceNew:    true,
+		Optional:    true,
 	}
 
 	provisionerNameDSSchema = &schema.Schema{
 		Type:        schema.TypeString,
 		Description: "Cluster provisioner name",
-		Required:    true,
-		ForceNew:    true,
+		Optional:    true,
 	}
 
 	sortBySchema = &schema.Schema{