Merge pull request #122 from vmware/bugfix/ip-pool

Respect IP Pool configuration for NSX subresource

Author: spacegospod

internal/provider/resource_vcf_instance_test.go

@@ -145,6 +145,17 @@ func testAccCheckVcfSddcConfigBasic() string {
 		vip_fqdn = "vip-nsx-mgmt"
 		license = %q
 		transport_vlan_id = 0
+		ip_address_pool {
+		  name = "static-pool-1"
+		  subnet {
+		    cidr = "10.0.8.4/24"
+		    gateway = "10.0.8.253"
+		    ip_address_pool_range {
+		      start = "10.0.8.4"
+		      end = "10.0.8.16"
+		    }
+		  }
+		}
 	  }
 	  vsan {
 		license = %q

internal/sddc/sddc_nsx_subresource.go

@@ -158,6 +158,14 @@ func GetNsxSpecFromSchema(rawData []interface{}) *models.SDDCNSXTSpec {
 	if overLayTransportZoneData := getTransportZoneFromSchema(data["overlay_transport_zone"].([]interface{})); overLayTransportZoneData != nil {
 		nsxtSpecBinding.OverLayTransportZone = overLayTransportZoneData
 	}
+
+	if ipAddressPoolRaw, ok := data["ip_address_pool"]; ok && !validation_utils.IsEmpty(ipAddressPoolRaw) {
+		ipAddressPoolList := ipAddressPoolRaw.([]interface{})
+		// Only one IP Address pool spec is allowed in the resource
+		if ipAddressPoolSpec, err := network.GetIpAddressPoolSpecFromSchema(ipAddressPoolList[0].(map[string]interface{})); err == nil {
+			nsxtSpecBinding.IPAddressPoolSpec = ipAddressPoolSpec
+		}
+	}
 	return nsxtSpecBinding
 }