refactor: slice initializations to var syntax (#358)

Author: tenthirtyam

internal/cluster/cluster_operations.go

@@ -248,7 +248,7 @@ func TryConvertToClusterSpec(object map[string]interface{}) (*vcf.ClusterSpec, e
 	if vdsRaw, ok := object["vds"]; ok {
 		vdsList := vdsRaw.([]interface{})
 		if len(vdsList) > 0 {
-			vdsSpecs := []vcf.VdsSpec{}
+			var vdsSpecs []vcf.VdsSpec
 			for _, vdsListEntry := range vdsList {
 				vdsSpec, err := network.TryConvertToVdsSpec(vdsListEntry.(map[string]interface{}))
 				if err != nil {
@@ -321,7 +321,7 @@ func tryConvertToClusterDatastoreSpec(object map[string]interface{}, clusterName
 	if nfsDatastoresRaw, ok := object["nfs_datastores"]; ok && !validationUtils.IsEmpty(nfsDatastoresRaw) {
 		nfsDatastoresList := nfsDatastoresRaw.([]interface{})
 		if len(nfsDatastoresList) > 0 {
-			specs := []vcf.NfsDatastoreSpec{}
+			var specs []vcf.NfsDatastoreSpec
 			for _, nfsDatastoreListEntry := range nfsDatastoresList {
 				nfsDatastoreSpec, err := datastores.TryConvertToNfsDatastoreSpec(
 					nfsDatastoreListEntry.(map[string]interface{}))
@@ -337,7 +337,7 @@ func tryConvertToClusterDatastoreSpec(object map[string]interface{}, clusterName
 	if vvolDatastoresRaw, ok := object["vvol_datastores"]; ok && !validationUtils.IsEmpty(vvolDatastoresRaw) {
 		vvolDatastoresList := vvolDatastoresRaw.([]interface{})
 		if len(vvolDatastoresList) > 0 {
-			specs := []vcf.VvolDatastoreSpec{}
+			var specs []vcf.VvolDatastoreSpec
 			for _, vvolDatastoreListEntry := range vvolDatastoresList {
 				vvolDatastoreSpec, err := datastores.TryConvertToVvolDatastoreSpec(
 					vvolDatastoreListEntry.(map[string]interface{}))

internal/cluster/host_spec_subresource.go

@@ -138,7 +138,7 @@ func TryConvertToHostSpec(object map[string]interface{}) (*vcf.HostSpec, error)
 		vmNicsList := vmNicsRaw.([]interface{})
 		if len(vmNicsList) > 0 {
 			result.HostNetworkSpec = &vcf.HostNetworkSpec{}
-			vmNics := []vcf.VmNic{}
+			var vmNics []vcf.VmNic
 			for _, vmNicListEntry := range vmNicsList {
 				vmNic, err := network.TryConvertToVmNic(vmNicListEntry.(map[string]interface{}))
 				if err != nil {

internal/datastores/vmfs_datastore_subresource.go

@@ -35,7 +35,7 @@ func TryConvertToVmfsDatastoreSpec(object map[string]interface{}) (*vcf.VmfsData
 		return nil, fmt.Errorf("cannot convert to VmfsDatastoreSpec, datastore_names is required")
 	}
 	result := &vcf.VmfsDatastoreSpec{}
-	specs := []vcf.FcSpec{}
+	var specs []vcf.FcSpec
 	for _, datastoreName := range datastoreNames {
 		specs = append(specs, vcf.FcSpec{DatastoreName: datastoreName})
 	}

internal/datastores/vsan_remote_datastore_cluster_subresource.go

@@ -35,7 +35,7 @@ func TryConvertToVSANRemoteDatastoreClusterSpec(object map[string]interface{}) (
 		return nil, fmt.Errorf("cannot convert to VSANRemoteDatastoreClusterSpec, datastore_uuids is required")
 	}
 	result := &vcf.VsanRemoteDatastoreClusterSpec{}
-	specs := []vcf.VsanRemoteDatastoreSpec{}
+	var specs []vcf.VsanRemoteDatastoreSpec
 	for _, datastoreUuid := range datastoreUuids {
 		specs = append(specs, vcf.VsanRemoteDatastoreSpec{DatastoreUuid: datastoreUuid})
 	}

internal/network/ip_address_pool_subresource.go

@@ -102,7 +102,7 @@ func GetIpAddressPoolSpecFromSchema(object map[string]interface{}) (*vcf.IpAddre
 	if subnetsRaw, ok := object["subnet"]; ok {
 		subnetsList := subnetsRaw.([]interface{})
 		if len(subnetsList) > 0 {
-			subnets := []vcf.IpAddressPoolSubnetSpec{}
+			var subnets []vcf.IpAddressPoolSubnetSpec
 			for _, subnetsListEntry := range subnetsList {
 				ipAddressPoolSubnetSpec, err := getIpAddressPoolSubnetSpecFromSchema(subnetsListEntry.(map[string]interface{}))
 				if err != nil {

internal/network/vds_subresource.go

@@ -68,7 +68,7 @@ func TryConvertToVdsSpec(object map[string]interface{}) (*vcf.VdsSpec, error) {
 	if portgroupsRaw, ok := object["portgroup"]; ok && !validationutils.IsEmpty(portgroupsRaw) {
 		portgroupsList := portgroupsRaw.([]interface{})
 		if len(portgroupsList) > 0 {
-			portGroupSpecs := []vcf.PortgroupSpec{}
+			var portGroupSpecs []vcf.PortgroupSpec
 			for _, portgroupListEntry := range portgroupsList {
 				portgroupSpec, err := tryConvertToPortgroupSpec(portgroupListEntry.(map[string]interface{}))
 				if err != nil {
@@ -82,7 +82,7 @@ func TryConvertToVdsSpec(object map[string]interface{}) (*vcf.VdsSpec, error) {
 	if niocBandwidthAllocationsRaw, ok := object["nioc_bandwidth_allocations"]; ok && !validationutils.IsEmpty(niocBandwidthAllocationsRaw) {
 		niocBandwidthAllocationsList := niocBandwidthAllocationsRaw.([]interface{})
 		if len(niocBandwidthAllocationsList) > 0 {
-			specs := []vcf.NiocBandwidthAllocationSpec{}
+			var specs []vcf.NiocBandwidthAllocationSpec
 			for _, niocBandwidthAllocationListEntry := range niocBandwidthAllocationsList {
 				niocBandwidthAllocationSpec, err := tryConvertToNiocBandwidthAllocationSpec(
 					niocBandwidthAllocationListEntry.(map[string]interface{}))

internal/provider/data_host.go

@@ -345,7 +345,7 @@ func dataSourceHostRead(ctx context.Context, d *schema.ResourceData, meta interf
 	_ = d.Set("network_pool", networkPool)
 
 	// CPU information.
-	cpuCores := []map[string]interface{}{}
+	var cpuCores []map[string]interface{}
 	for _, core := range *host.Cpu.CpuCores {
 		cpuCore := map[string]interface{}{
 			"frequency_mhz": core.FrequencyMHz,
@@ -379,7 +379,7 @@ func dataSourceHostRead(ctx context.Context, d *schema.ResourceData, meta interf
 	_ = d.Set("compatible_storage_type", host.CompatibleStorageType)
 
 	// Storage information.
-	disks := []map[string]interface{}{}
+	var disks []map[string]interface{}
 	for _, disk := range *host.Storage.Disks {
 		diskInfo := map[string]interface{}{
 			"capacity_mb":  disk.CapacityMB,
@@ -400,7 +400,7 @@ func dataSourceHostRead(ctx context.Context, d *schema.ResourceData, meta interf
 	_ = d.Set("storage", storage)
 
 	// Physical NICs information.
-	physicalNics := []map[string]interface{}{}
+	var physicalNics []map[string]interface{}
 	for _, nic := range *host.PhysicalNics {
 		physicalNic := map[string]interface{}{
 			"device_name": nic.DeviceName,
@@ -413,7 +413,7 @@ func dataSourceHostRead(ctx context.Context, d *schema.ResourceData, meta interf
 	_ = d.Set("physical_nics", physicalNics)
 
 	// IP addresses information.
-	ipAddresses := []map[string]interface{}{}
+	var ipAddresses []map[string]interface{}
 	for _, ip := range *host.IpAddresses {
 		ipAddress := map[string]interface{}{
 			"ip_address": ip.IpAddress,