chore: update makefile

Updates the `GNUmakefile` to:

- Support HCL formatting in `docs/` and `examples/.
- Remove unneeded options.

Signed-off-by: Ryan Johnson <[email protected]>

Author: tenthirtyam

GNUmakefile

@@ -1,7 +1,6 @@
-TEST?=$$(go list ./... |grep -v 'vendor')
-GOFMT_FILES?=$$(find . -name '*.go' |grep -v vendor)
-WEBSITE_REPO=github.com/hashicorp/terraform-website
-PKG_NAME=vmc
+TEST ?= $(shell go list ./... | grep -v 'vendor')
+GOFMT_FILES ?= $(shell find . -name '*.go' | grep -v vendor)
+PKG_NAME = vmc
 
 default: build
 
@@ -15,71 +14,40 @@ init:
 debug:
 	go build -gcflags="all=-N -l"
 
-plan: init
-	terraform plan
-
-apply: init
-	terraform apply
-
 test: fmtcheck
 	go test $(TEST) || exit 1
-	echo $(TEST) | \
-		xargs -t -n4 go test $(TESTARGS) -timeout=30s -parallel=4
+	echo $(TEST) | xargs -t -n4 go test $(TESTARGS) -timeout=30s -parallel=4
 
 testacc:
 	TF_ACC=1 go test $(TEST) -v $(TESTARGS) -timeout 240m
 
 debugacc: fmtcheck
-	TF_ACC=1 dlv test $(TEST) -- -test.v $(TESTARGS)
+	TF_ACC=1 dlv test -o /dev/null $(TEST) -- -test.v $(TESTARGS)
 
 vet:
 	@echo "go vet ."
-	@go vet $$(go list ./... | grep -v vendor/) ; if [ $$? -eq 1 ]; then \
-		echo ""; \
-		echo "Vet found suspicious constructs. Please check the reported constructs"; \
-		echo "and fix them if necessary before submitting the code for review."; \
-		exit 1; \
-	fi
+	@go vet $(shell go list ./... | grep -v vendor/) || { echo ""; echo "Vet found suspicious constructs. Please fix them before submitting your code."; exit 1; }
 
 fmt:
 	gofmt -w -s $(GOFMT_FILES)
 
 fmtcheck:
-	@sh -c "'$(CURDIR)/scripts/gofmtcheck.sh'"
+	@$(CURDIR)/scripts/gofmtcheck.sh
 
 test-compile:
-	@if [ "$(TEST)" = "./..." ]; then \
-		echo "ERROR: Set TEST to a specific package. For example,"; \
-		echo "  make test-compile TEST=./$(PKG_NAME)"; \
-		exit 1; \
-	fi
+	@if [ "$(TEST)" = "./..." ]; then echo "ERROR: Set TEST to a specific package. For example,"; echo "  make test-compile TEST=./$(PKG_NAME)"; exit 1; fi
 	go test -c $(TEST) $(TESTARGS)
 
-lint:
-	@echo "==> Checking source code against linters..."
-	@golangci-lint --disable errcheck run ./$(PKG_NAME)/...
-
 tools:
-	GO111MODULE=on go install github.com/client9/misspell/cmd/misspell
 	GO111MODULE=on go install github.com/golangci/golangci-lint/cmd/golangci-lint
+	GO111MODULE=on go install -mod=mod github.com/katbyte/terrafmt
 
-website:
-ifeq (,$(wildcard $(GOPATH)/src/$(WEBSITE_REPO)))
-	echo "$(WEBSITE_REPO) not found in your GOPATH (necessary for layouts and assets), get-ting..."
-	git clone https://$(WEBSITE_REPO) $(GOPATH)/src/$(WEBSITE_REPO)
-endif
-	echo $(MAKE)
-	@$(MAKE) -C $(GOPATH)/src/$(WEBSITE_REPO) website-provider PROVIDER_PATH=$(shell pwd) PROVIDER_NAME=$(PKG_NAME)
-
-website-test:
-ifeq (,$(wildcard $(GOPATH)/src/$(WEBSITE_REPO)))
-	echo "$(WEBSITE_REPO) not found in your GOPATH (necessary for layouts and assets), get-ting..."
-	git clone https://$(WEBSITE_REPO) $(GOPATH)/src/$(WEBSITE_REPO)
-endif
-	@$(MAKE) -C $(GOPATH)/src/$(WEBSITE_REPO) website-provider-test PROVIDER_PATH=$(shell pwd) PROVIDER_NAME=$(PKG_NAME)
+docs-hcl-lint:
+	@echo "==> Checking HCL formatting..."
+	@terrafmt diff ./docs --check --pattern '*.md' --quiet || (echo; echo "Unexpected HCL differences. Run 'make docs-hcl-fix'."; exit 1)
 
-website-lint:
-	@echo "==> Checking website against linters..."
-	@misspell -error -source=text website/
+docs-hcl-fix:
+	@echo "==> Applying HCL formatting..."
+	@terrafmt fmt ./docs --pattern '*.md'
 
-.PHONY: build  init plan apply test testacc debugacc fmt fmtcheck vet lint tools test-compile website website-lint website-test test-compile
+.PHONY: build init test testacc debugacc fmt fmtcheck vet tools test-compile docs-hcl-lint docs-hcl-fix