Add support for `storage_filter_type` and `tags_to_match` in storage profiles

[davidsedano01]

Code of Conduct

This project has a Code of Conduct that all participants are expected to understand and follow:

• I have read and agree to the project's Code of Conduct

Description

The current implementation of vRA storage profiles in the Terraform provider does not support the storage_filter_type and tags_to_match fields that are available in the latest vRA IaaS API.

According to the API specification:

• storage_filter_type: Defines filter type for adding storage objects (datastores) to the storage profile. Valid values are: INCLUDE_ALL, TAG_BASED, MANUAL. Defaults to INCLUDE_ALL.
• tags_to_match: A set of tag keys and optional values to be set on datastores to be included in this storage profile when storage_filter_type is TAG_BASED.

This enhancement would allow users to leverage storage filtering capabilities when creating storage profiles through Terraform.

Describe alternatives you've considered

Currently users must manually configure storage profile associations without the ability to filter by tags. The only workarounds are:

1. Use the vRA UI to configure these settings after creation
2. Use the vRA REST API directly
3. Manually specify all datastores without filtering

References

• vRA IaaS API Swagger documentation shows these fields are supported in the StorageProfileVsphereSpecification
• Related code: https://github.com/vmware/terraform-provider-vra/blob/main/vra/resource_storage_profile_vsphere.go

Community Note

• 👍 Please vote on this issue if you would find this enhancement useful
• Please do not leave "+1" or other comments that do not add relevant new information or questions
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

[davidsedano01]

Bump!!!

Also, just noticed I am not able to assign multiple datastores to the same Storage Profile. If I provide multiple datastore_id, it will create a storage profile for each datastore_id, but the storage profile name will be duplicated.

Example vars defined in tfvars:

name = StorageA
datastore_id = ["123", "456", "789"]

Terraform apply will create:

Storage profile (1)
name = StorageA
datastore_id = "123"

Storage profile (2)
name = StorageA
datastore_id = "456"

Storage profile (3)
name = StorageA
datastore_id = "789"

If I manually create the storage profile via web interface, i can manually assign multiple datastores clusters to the same profile. Or better if i can set "Dynamically include based of tags" we can manage using "tagsToMatch" and we don't have to worry if the vCenter team adds storage in the future. They set the tags and Aria picks it up on its next discovery.

Storage profile
name = StorageA
datastore_id = "123", "456", "789"

[davidsedano01]

Disregard my previous comment.

I just took another look at my terraform code, and i noticed my "for_each" loop was in the wrong place.

I was trying to figure out a way to attach multiple datastore id's to a single datastore profile resource. However you can not. According to the "resource_storage_profile_vsphere.go":
"datastore_id": {Type: schema.TypeString, ..."

When re-writing, Datastore should be able to be assigned by "Manual", "TagsToMatch", or "ALL".
Manual should allow you to provide multiple datastore to the same profile. TagsToMatch should allow filtering by tags. "ALL" is all.