Deployment update request does not handle http code 400

[gaojunling-wq]

Code of Conduct

This project has a Code of Conduct that all participants are expected to understand and follow:
[] I have read and agree to the project's Code of Conduct

vRA Version

vRA 8.18.1

Terraform Version

1.13.3

vRA Terraform Provider Version

0.15.0

Affected Resource(s)

vra_deployment with catalog item (cloud template)

Expected Behavior

Cloud template has configured to has enum list for an input:
During provisioning request, if sent bad value, provider get correct message for user:
Error: [POST /catalog/api/items/{id}/request][400] requestCatalogItemInstancesUsingPOST1BadRequest &{Message:input1: '"data"' is invalid. Expected value in '["titi", "toto"]'. StatusCode:400}

During update request, if sent bad value, provider should throw same error for input validation
Error: [POST /catalog/api/items/{id}/request][400] requestCatalogItemInstancesUsingPOST1BadRequest &{Message:input1: '"data"' is invalid. Expected value in '["titi", "toto"]'. StatusCode:400}

Actual Behavior

Actually we got an error message without any detail:
Error: response status code does not match any response statuses defined for this endpoint in the swagger spec (status 400): {}

In fact, the error message is sent back by vRA http 400 but not handled by provider correctly:
{
"message": "Validation failed with: $.inputs.input1: Value 'data' is not in list of valid values ["titi", "toto"]",
"statusCode": 400,
"errorCode": 24002
}

Steps to Reproduce

1. have a cloud template with enum list for a list:

inputs:
input1:
type: string
default: toto
enum:
- titi
- toto

2. deploy the vm with terraform (with value "toto" for input1 )and try update it with a bad value (value "data" for input1 )

Screenshots

Debug output

[tenthirtyam]

This is an issue in vmware/vra-sdk-go; the library needs to be updated to add a handler for HTTP 400 responses.

In the library, under pkg/client/deployment_actions/submit_deployment_action_request_using_post2_responses.go shows that the ReadResponse function only handles these HTTP status codes:

• 200 (OK)
• 401 (Unauthorized)
• 403 (Forbidden)
• 404 (Not Found)

So it falls through with the error observed.

default:
    return nil, runtime.NewAPIError("response status code does not match any response statuses defined for this endpoint in the swagger spec", response, response.Code())

This will require a dependency fix and an update in the provider.

[frodenas]

The vra-sdk-go, which handles all client operations, is auto-generated from the different vRA services' swagger definitions (see vra-catalog-deployment.json for example). The issue here is in upstream vRA, as it isn't advertising the 400 HTTP response code in the swagger definition (see POST request responses). I've opened an internal issue (VCFCON-34162) for the vRA deployment service to fix this.