feat: add support for rdm disks

Author: sumitAgrawal007

docs/data-sources/vmfs_disks.md

@@ -58,3 +58,8 @@ the output `disks` attribute below, which is lexicographically sorted.
 
 * `disks` - A lexicographically sorted list of devices discovered by the
   operation, matching the supplied `filter`, if provided.
+  
+* `disk_details` - List of disks discovered by the operation with more details about them. The order matches that of `disks`
+  * `display_name` - Display name of the disk 
+  * `device_path` - Path of the physical volume of the disk.
+  * `capacity_gb` - Capacity of the disk in GiB.

vsphere/data_source_vsphere_vmfs_disks.go

@@ -11,6 +11,8 @@ import (
 	"sort"
 	"time"
 
+	"github.com/hashicorp/terraform-provider-vsphere/vsphere/internal/helper/structure"
+
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
 	"github.com/vmware/govmomi/vim25/mo"
@@ -40,10 +42,32 @@ func dataSourceVSphereVmfsDisks() *schema.Resource {
 			},
 			"disks": {
 				Type:        schema.TypeList,
-				Description: "The names of the disks discovered by the search.",
+				Description: "The canonical names of the disks discovered by the search.",
 				Computed:    true,
 				Elem:        &schema.Schema{Type: schema.TypeString},
 			},
+			"disk_details": {
+				Type:        schema.TypeList,
+				Description: "The details of the disks discovered by the search.",
+				Computed:    true,
+				Elem: &schema.Resource{Schema: map[string]*schema.Schema{
+					"display_name": {
+						Type:        schema.TypeString,
+						Computed:    true,
+						Description: "Display name of the disk.",
+					},
+					"device_path": {
+						Type:        schema.TypeString,
+						Computed:    true,
+						Description: "Path of the physical volume of the disk.",
+					},
+					"capacity_gb": {
+						Type:        schema.TypeInt,
+						Computed:    true,
+						Description: "Capacity of the disk in GiB.",
+					},
+				}},
+			},
 		},
 	}
 }
@@ -74,19 +98,35 @@ func dataSourceVSphereVmfsDisksRead(d *schema.ResourceData, meta interface{}) er
 	d.SetId(time.Now().UTC().String())
 
 	var disks []string
+	diskDetailsMap := make(map[string]map[string]interface{})
 	for _, sl := range hss.StorageDeviceInfo.ScsiLun {
 		if hsd, ok := sl.(*types.HostScsiDisk); ok {
 			if matched, _ := regexp.MatchString(d.Get("filter").(string), hsd.CanonicalName); matched {
+				disk := make(map[string]interface{})
+				disk["display_name"] = hsd.DisplayName
+				disk["device_path"] = hsd.DevicePath
+				block := hsd.Capacity.Block
+				blockSize := int64(hsd.Capacity.BlockSize)
+				disk["capacity_gb"] = structure.ByteToGiB(block * blockSize)
 				disks = append(disks, hsd.CanonicalName)
+				diskDetailsMap[hsd.CanonicalName] = disk
 			}
 		}
 	}
-
 	sort.Strings(disks)
+	// use the now sorted name list to create a matching order details list
+	diskDetails := make([]map[string]interface{}, len(disks))
+	for i, name := range disks {
+		diskDetails[i] = diskDetailsMap[name]
+	}
 
 	if err := d.Set("disks", disks); err != nil {
 		return fmt.Errorf("error saving results to state: %s", err)
 	}
 
+	if err := d.Set("disk_details", diskDetails); err != nil {
+		return fmt.Errorf("error saving results to state: %s", err)
+	}
+
 	return nil
 }

vsphere/data_source_vsphere_vmfs_disks_test.go

@@ -29,6 +29,12 @@ func TestAccDataSourceVSphereVmfsDisks_basic(t *testing.T) {
 					testCheckOutputBool("found", "true"),
 				),
 			},
+			{
+				Config: testAccDataSourceVSphereVmfsDisksInfoConfig(),
+				Check: resource.ComposeTestCheckFunc(
+					testCheckOutputBool("found", "true"),
+				),
+			},
 		},
 	})
 }
@@ -82,3 +88,26 @@ output "found" {
 		os.Getenv("TF_VAR_VSPHERE_ESXI1"),
 	)
 }
+
+func testAccDataSourceVSphereVmfsDisksInfoConfig() string {
+	return fmt.Sprintf(`
+%s
+
+data "vsphere_host" "esxi_host" {
+  name          = "%s"
+  datacenter_id = "${data.vsphere_datacenter.rootdc1.id}"
+}
+
+data "vsphere_vmfs_disks" "available" {
+  host_system_id = "${data.vsphere_host.esxi_host.id}"
+  rescan         = true
+}
+
+output "found" {
+  value = "${length(data.vsphere_vmfs_disks.available.disk_details) >= 1 ? "true" : "false" }"
+}
+`,
+		testhelper.CombineConfigs(testhelper.ConfigDataRootDC1(), testhelper.ConfigDataRootPortGroup1()),
+		os.Getenv("TF_VAR_VSPHERE_ESXI1"),
+	)
+}

vsphere/helper_test.go

@@ -393,9 +393,10 @@ func testRenameVMFirstDisk(s *terraform.State, resourceName string, newDiskName
 	var dcSpec []types.BaseVirtualDeviceConfigSpec
 	for _, d := range vprops.Config.Hardware.Device {
 		if oldDisk, ok := d.(*types.VirtualDisk); ok {
+			backing, _ := virtualdevice.GetBackingForDisk(oldDisk)
 			newFileName, err := virtualdisk.Move(
 				tVars.client,
-				oldDisk.Backing.(*types.VirtualDiskFlatVer2BackingInfo).FileName,
+				backing.GetFileName(),
 				dc,
 				newDiskName,
 				nil,
@@ -409,9 +410,9 @@ func testRenameVMFirstDisk(s *terraform.State, resourceName string, newDiskName
 						VirtualDeviceFileBackingInfo: types.VirtualDeviceFileBackingInfo{
 							FileName: newFileName,
 						},
-						ThinProvisioned: oldDisk.Backing.(*types.VirtualDiskFlatVer2BackingInfo).ThinProvisioned,
-						EagerlyScrub:    oldDisk.Backing.(*types.VirtualDiskFlatVer2BackingInfo).EagerlyScrub,
-						DiskMode:        oldDisk.Backing.(*types.VirtualDiskFlatVer2BackingInfo).DiskMode,
+						ThinProvisioned: backing.GetThinProvisioned(),
+						EagerlyScrub:    backing.GetEagerlyScrub(),
+						DiskMode:        backing.GetDiskMode(),
 					},
 				},
 			}