`r/virtual_machine`: add support to manage CD-ROM connection state

[felipeaom]

vSphere Provider Version

version = "1.15.0"

vSphere Version

VMware Version: 6.7.0 Update 3 (Build 14320388)

Affected Resource(s)

• vsphere_virtual_machine

Terraform Configuration Files

resource "vsphere_virtual_machine" "virtualmachine" {
  name                       = var.vs_vmname
  resource_pool_id           = data.vsphere_resource_pool.pool.id
  datastore_id               = data.vsphere_datastore.datastore.id
  force_power_off            = true
  shutdown_wait_timeout      = 1
  
  num_cpus                   = "4"
  memory                     = "8192"
  wait_for_guest_net_timeout = 0
  guest_id                   = var.vs_guestid
  nested_hv_enabled          = true
  
  network_interface {
    network_id   = data.vsphere_network.networking.id
    adapter_type = "vmxnet3"
  }
  
  cdrom {
    datastore_id = data.vsphere_datastore.datastore.id
    path         = var.vs_iso_custom
  }

  disk {
    size             = "300"
    label            = "disk0.vmdk"
    thin_provisioned = false
  }

Explaining the code

My code is to create a VM to use a custom ISO to do a silent installation. However, when the VM is turned on, the "connect" flag is not marked in the CD / DVD settings. This way I need to shut down the VM, mark the flag and start again to boot correctly. Does anyone have any idea if it is a BUG or if it has an option in the code to insert?

[MarkUlmer]

I wanted to provide a possibly relevant documentation for connect and disconnect:

https://developer.vmware.com/docs/vsphere-automation/latest/vcenter/api/vcenter/vm/vm/hardware/cdrom/cdromactionconnect/post/

https://developer.vmware.com/docs/vsphere-automation/latest/vcenter/api/vcenter/vm/vm/hardware/cdrom/cdromactiondisconnect/post/

Seems like adding something like this would address the expected behavior. action = "connect" | "disconnect"

[github-actions]

Marking this issue as stale due to inactivity in the past 180 days. This helps us focus on the active issues. If this issue is reproducible with the latest version of the provider, please comment. If this issue receives no comments in the next 30 days it will automatically be closed.
If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

[tenthirtyam]

Updating this issue as a request for enhancement.

Ryan

[tenthirtyam]

ℹ️ More relevant from vmware/govmomi:

type VirtualDeviceConnectInfo struct {
	DynamicData

	MigrateConnect    string `xml:"migrateConnect,omitempty"`
	StartConnected    bool   `xml:"startConnected"`
	AllowGuestControl bool   `xml:"allowGuestControl"`
	Connected         bool   `xml:"connected"`
	Status            string `xml:"status,omitempty"`
}

Specifically, possible use of StartConnected and:or Connected.

If you look at the r/virtual_machine_cdrom_subresource it uses the default CreateCdrom from vmware/govmomi versus using its own implementation to control the state of the device connection.

https://github.com/hashicorp/terraform-provider-vsphere/blob/a9ba3f32cb74cf8eef83b8bba0204d2ebc91d592/vsphere/internal/virtualdevice/virtual_machine_cdrom_subresource.go#L432-L435

Potential Configuration

resource "vsphere_virtual_machine" "vm" {
  #... other configuration...
  cdrom {
    datastore_id    = data.vsphere_datastore.datastore.id
    path            = var.iso_path
    connected       = true
    start_connected = true
  }
  #... other configuration...
}

Ryan Johnson
Staff II Solutions Architect | VMware, Inc.