use playwright-firefox such that npm install does not download other browsers

Author: vogler

Dockerfile

@@ -7,10 +7,8 @@ FROM ubuntu:jammy
 # https://github.com/hadolint/hadolint/wiki/DL4006
 SHELL ["/bin/bash", "-o", "pipefail", "-c"]
 ARG DEBIAN_FRONTEND=noninteractive
-ENV PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD true
 
-# Install up-to-date node & npm, deps for virtual screen & noVNC, browser, pip for apprise.
-# Playwright needs --with-deps for firefox.
+# Install up-to-date node & npm, deps for virtual screen & noVNC, firefox, pip for apprise.
 RUN apt-get update \
     && apt-get install --no-install-recommends -y curl ca-certificates \
     && curl -fsSL https://deb.nodesource.com/setup_19.x | bash - \
@@ -50,8 +48,11 @@ RUN pip install apprise
 WORKDIR /fgc
 COPY package*.json ./
 
-# If firefox is installed (~/.cache/ms-playwright/firefox-*) before `npm install` it may be a newer version than in package.json and playwright will not find it; system deps are installed sep. via apt above to avoid having to pin the version there.
-RUN npm install && npx playwright install firefox
+# Playwright installs patched firefox to ~/.cache/ms-playwright/firefox-*
+# Requires some system deps to run (see install-deps above).
+RUN npm install
+# Old: PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD + install firefox (had to be done after `npm install` to get the correct version). Now: playwright-firefox as npm dep and `npm install` will only install that.
+# RUN npx playwright install firefox
 
 COPY . .
 

README.md

@@ -31,10 +31,10 @@ Data (including json files with claimed games, codes to redeem, screenshots) is
 
 1. [Install Node.js](https://nodejs.org/en/download)
 2. Clone/download this repository and `cd` into it in a terminal
-3. Run `npm install && npx playwright install firefox`
+3. Run `npm install`
 4. Run `pip install apprise` to install [apprise](https://github.com/caronc/apprise) if you want notifications
 
-This downloads Firefox to a cache in home ([doc](https://playwright.dev/docs/browsers#managing-browser-binaries)).
+During `npm install` Playwright will download its Firefox to a cache in home ([doc](https://playwright.dev/docs/browsers#managing-browser-binaries)).
 If you are missing some dependencies for the browser on your system, you can use `sudo npx playwright install firefox --with-deps`.
 
 If you don't want to use Docker for quasi-headless mode, you could run inside a virtual machine, on a server, or you wake your PC at night to avoid being interrupted.

epic-games.js

@@ -1,4 +1,4 @@
-import { firefox } from 'playwright'; // stealth plugin needs no outdated playwright-extra
+import { firefox } from 'playwright-firefox'; // stealth plugin needs no outdated playwright-extra
 import { authenticator } from 'otplib';
 import path from 'path';
 import { existsSync, writeFileSync } from 'fs';

gog.js

@@ -1,4 +1,4 @@
-import { firefox } from 'playwright'; // stealth plugin needs no outdated playwright-extra
+import { firefox } from 'playwright-firefox'; // stealth plugin needs no outdated playwright-extra
 import path from 'path';
 import { jsonDb, datetime, filenamify, prompt, notify, html_game_list } from './util.js';
 import { cfg } from './config.js';

package-lock.json

@@ -15,7 +15,7 @@
     "enquirer": "^2.3.6",
     "lowdb": "^5.1.0",
     "otplib": "^12.0.1",
-    "playwright": "^1.31.0",
+    "playwright-firefox": "^1.31.0",
     "puppeteer-extra-plugin-stealth": "^2.11.1"
   },
   "repository": {

package.json

@@ -1,4 +1,4 @@
-import { firefox } from 'playwright'; // stealth plugin needs no outdated playwright-extra
+import { firefox } from 'playwright-firefox'; // stealth plugin needs no outdated playwright-extra
 import { authenticator } from 'otplib';
 import path from 'path';
 import { jsonDb, datetime, stealth, filenamify, prompt, notify, html_game_list } from './util.js';